Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new CLI parameters to support for proxy config #1878

Merged
merged 4 commits into from
Jun 20, 2020

Conversation

pasankav
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/pasankav/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

@pasankav pasankav requested a review from fengzhou-msft June 12, 2020 06:41
@fengzhou-msft fengzhou-msft requested a review from arrownj June 12, 2020 08:57
@yonzhan yonzhan added this to the S171 milestone Jun 12, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 12, 2020

connectedk8s

@fengzhou-msft fengzhou-msft merged commit c4799e6 into Azure:master Jun 20, 2020
@fengzhou-msft
Copy link
Member

@pasankav I just realized that you need to bump the version in setup.py too. Please submit another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants