Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "spring-cloud: add support to enable/disable MSI (#1523)" #1622

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Revert "spring-cloud: add support to enable/disable MSI (#1523)" #1622

merged 1 commit into from
Apr 30, 2020

Conversation

leonard520
Copy link
Contributor

This reverts commit 666bab7.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan yonzhan requested a review from qwordy April 29, 2020 09:50
@yonzhan yonzhan added this to the S169 milestone Apr 29, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 29, 2020

add to S169

@qwordy
Copy link
Member

qwordy commented Apr 30, 2020

Is there any reason?

@leonard520
Copy link
Contributor Author

Is there any reason?

We have another spring cloud feature whose backend is ready and want to deliver soon.
#1419
In the meanwhile, our feature backend will be ready in another 3 weeks.
That's why I need to revert the CLI part for ours so that my teammate can release theirs in time.
Sorry fro the inconvenience brought.

@yungezz
Copy link
Member

yungezz commented Apr 30, 2020

Is there any reason?

We have another spring cloud feature whose backend is ready and want to deliver soon.
#1419
In the meanwhile, our feature backend will be ready in another 3 weeks.
That's why I need to revert the CLI part for ours so that my teammate can release theirs in time.
Sorry fro the inconvenience brought.

HI @leonard520 in future if you have features under development, not ready to release, you can still work on your Azure CLI PR at same time, just label Azure CLI PR with do-not-merge, we'll review it but not merge it.

@qwordy qwordy merged commit 0f9aa58 into Azure:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants