-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spring cloud - custom domain - cli #1419
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
Upgrade the |
spring cloud |
updated. |
text: az spring-cloud certificate list -o table | ||
""" | ||
|
||
helps['spring-cloud certificate remove'] = """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spring-cloud certificate remove
spring-cloud app custom-domain delete
I think the verb should be consistent. I prefer "delele"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use those verbs in pair right? add/remove, create/delete, bind/unbind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I would suggest:
spring-cloud certificate remove
spring-cloud app custom-domain unbind
|
||
@record_only() | ||
class CustomDomainTests(ScenarioTest): | ||
def test_bind_cert_to_domain(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add @ResourceGroupPreparer(name_prefix='cli_test_bind_cert_to_domain')
Some checks were not successful |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
super(CertificateResourcePaged, self).__init__(*args, **kwargs) | ||
class CustomDomainResourcePaged(Paged): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lack of blank line
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.