Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring cloud - custom domain - cli #1419

Merged
merged 33 commits into from
May 8, 2020
Merged

spring cloud - custom domain - cli #1419

merged 33 commits into from
May 8, 2020

Conversation

1openwindow
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/1openwindow/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

@yonzhan yonzhan requested review from qwordy and mmyyrroonn and removed request for qwordy and mmyyrroonn March 19, 2020 11:15
@yungezz yungezz requested a review from fengzhou-msft March 19, 2020 12:34
@xgugeng
Copy link

xgugeng commented Mar 28, 2020

Upgrade the VERSION in setup.py and history.rst since it would be a feature release

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 28, 2020

spring cloud

@yungezz yungezz assigned fengzhou-msft and unassigned yungezz Mar 28, 2020
@1openwindow
Copy link
Contributor Author

Upgrade the VERSION in setup.py and history.rst since it would be a feature release

updated.

text: az spring-cloud certificate list -o table
"""

helps['spring-cloud certificate remove'] = """
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spring-cloud certificate remove
spring-cloud app custom-domain delete

I think the verb should be consistent. I prefer "delele"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use those verbs in pair right? add/remove, create/delete, bind/unbind

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I would suggest:

spring-cloud certificate remove
spring-cloud app custom-domain unbind


@record_only()
class CustomDomainTests(ScenarioTest):
def test_bind_cert_to_domain(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add @ResourceGroupPreparer(name_prefix='cli_test_bind_cert_to_domain')

@qwordy
Copy link
Member

qwordy commented Apr 30, 2020

Some checks were not successful

@fengzhou-msft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Comment on lines +66 to +67
super(CertificateResourcePaged, self).__init__(*args, **kwargs)
class CustomDomainResourcePaged(Paged):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lack of blank line

@yungezz yungezz merged commit cf586cc into Azure:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants