spring-cloud: add support to enable/disable MSI #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgugeng
reviewed
Apr 8, 2020
xgugeng
reviewed
Apr 8, 2020
xgugeng
reviewed
Apr 8, 2020
|
|
||
| helps['spring-cloud app identity remove'] = """ | ||
| type: command | ||
| short-summary: Remove managed service identity from a app. |
xgugeng
reviewed
Apr 8, 2020
xgugeng
reviewed
Apr 8, 2020
| @@ -45,6 +45,8 @@ def load_arguments(self, _): | |||
| with self.argument_context('spring-cloud app create') as c: | |||
| c.argument( | |||
| 'is_public', arg_type=get_three_state_flag(), help='If true, assign public domain', default=False) | |||
| c.argument('assign_identity', arg_type=get_three_state_flag(), | |||
| help='Generate and assign an Azure Active Directory Identity for this app for use with key management services like Azure KeyVault.') | |||
xgugeng
reviewed
Apr 8, 2020
|
|
||
| none = "None" | ||
| system_assigned = "SystemAssigned" | ||
| user_assigned = "UserAssigned" |
There was a problem hiding this comment.
keep none and system_assigned only, since the other two is not supported yet. Never mind, our backend handles the other two well
|
hi @fengzhou-msft could you pls help to look at it? thanks |
yungezz
approved these changes
Apr 8, 2020
| @@ -425,6 +439,37 @@ def app_tail_log(cmd, client, resource_group, service, name, instance=None, foll | |||
| raise exceptions[0] | |||
|
|
|||
|
|
|||
| def app_identity_assign(cmd, client, resource_group, service, name): | |||
| app_resource = models.AppResource() | |||
| identity = models.ManagedIdentityProperties(type="systemassigned") | |||
There was a problem hiding this comment.
do you have plan to support other type? if yes better to expose type as a param with default value
There was a problem hiding this comment.
Not yet. But we can refactor code if we will support in future.
fengzhou-msft
approved these changes
Apr 9, 2020
xgugeng
reviewed
Apr 9, 2020
| """ | ||
|
|
||
| helps['spring-cloud app identity assign'] = """ | ||
| type: command | ||
| short-summary: Enable managed service identity on an app. | ||
| examples: | ||
| - name: Enable managed service identity on an app. |
There was a problem hiding this comment.
The example provided is for system-assigned MSI only
yucwan
reviewed
Apr 9, 2020
| @@ -45,6 +45,8 @@ def load_arguments(self, _): | |||
| with self.argument_context('spring-cloud app create') as c: | |||
| c.argument( | |||
| 'is_public', arg_type=get_three_state_flag(), help='If true, assign public domain', default=False) | |||
| c.argument('assign_identity', arg_type=get_three_state_flag(), | |||
| help='Manage an app\'s managed service identity.') | |||
There was a problem hiding this comment.
If true, assign managed service identity.
added 2 commits
April 9, 2020 16:45
Refine text and examples
|
add to S168 |
qwordy
pushed a commit
that referenced
this pull request
Apr 30, 2020
This reverts commit 666bab7. Co-authored-by: Xiaoyun Ding <[email protected]>
3 tasks
qwordy
added a commit
that referenced
this pull request
May 27, 2020
* spring-cloud: add support to enable/disable MSI (#1523) * Update src/spring-cloud/HISTORY.md Co-authored-by: Feiyue Yu <[email protected]> Co-authored-by: Xiaoyun Ding <[email protected]> Co-authored-by: Feiyue Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.