-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--default-ssl-certificate flag for via CRD #160
--default-ssl-certificate flag for via CRD #160
Conversation
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.12.0 to 0.17.0. - [Commits](golang/crypto@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oliver King <[email protected]>
crd update temp unit test change fixed DefaultSSLCert in nginx test Changed check for empty defaulsslcert reverting unit test yaml Removed optional from Secret fields change sslSecret to secret
Pull Request Test Coverage Report for Build 7758505383
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good approach! Just left a few comments.
/ok-to-test sha=9374b59 |
/ok-to-test sha=7614337 |
/ok-to-test sha=a3b7596 |
/ok-to-test sha=a3b7596 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean, LGTM!
/ok-to-test sha=7eff4ed |
/ok-to-test sha=7eff4ed |
1 similar comment
/ok-to-test sha=7eff4ed |
@OliverMKing Is there a way to trigger receiving this enhancement in an active AKS cluster? It seems like it isn't live yet (at least in West Europe region), as i'm getting an unknown field error when trying to apply the setting... |
This will be released shortly. It's not released yet but I'll let you know when it is. It will be part of the AKS release notes when it is |
@OliverMKing I see the new version appeared on the AKS release notes but I cannot get it working on a newly deployed cluster (in a region that has the new version according to the release tracker). Is below syntax correct?
|
This should be documented in release notes, but it will only be available on clusters with k8s versions 1.30 and up. This is due to AKS addon breaking change policies. @sabbour for visibility. |
Description
Added functionality to use the --default-ssl-certificate flag via the CRD.
The defaultSSLCerfiticate field has a secret field with secretName and secretNamespace properties. From here it enters these in namespace/name format into the --default-ssl-certificate command line command and sets the default ssl certificate for the default HTTPS server
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?
Checklist: