Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inherit immutable fields in placeholder pod reconciler #153

Merged
merged 5 commits into from
Jan 23, 2024
Merged

inherit immutable fields in placeholder pod reconciler #153

merged 5 commits into from
Jan 23, 2024

Conversation

OliverMKing
Copy link
Collaborator

Description

Makes the placeholder pod reconciler compatible with immutable fields by inheriting the immutable fields into the reconciled manifests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

E2e and unit tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Jan 22, 2024

Pull Request Test Coverage Report for Build 7614611683

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 81.912%

Totals Coverage Status
Change from base Build 7492990816: -0.05%
Covered Lines: 2545
Relevant Lines: 3107

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=e000c15

@OliverMKing OliverMKing merged commit a530e19 into Azure:main Jan 23, 2024
9 checks passed
aamgayle pushed a commit to aamgayle/aks-app-routing-operator that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants