Skip to content

Commit

Permalink
Fixed e2e test
Browse files Browse the repository at this point in the history
  • Loading branch information
aamgayle committed Feb 2, 2024
1 parent a3b7596 commit 7eff4ed
Showing 1 changed file with 18 additions and 6 deletions.
24 changes: 18 additions & 6 deletions testing/e2e/suites/nginxIngressController.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,24 +77,36 @@ func nicTests(in infra.Provisioned) []test {
}

testNIC = manifests.NewNginxIngressController("nginx-ingress-controller", "nginxingressclass")
testNIC.Spec.DefaultSSLCertificate.Secret.Name = "Invalid+@Name"
testNIC.Spec.DefaultSSLCertificate.Secret.Namespace = "validnamespace"
testNIC.Spec.DefaultSSLCertificate = &v1alpha1.DefaultSSLCertificate{
Secret: &v1alpha1.Secret{
Name: "Invalid+@Name",
Namespace: "validnamespace",
},
}
lgr.Info("creating NginxIngressController with invalid Secret field")
if err := c.Create(ctx, testNIC); err == nil {
return fmt.Errorf("able to create NginxIngressController despite invalid Secret Name'%s'", testNIC.Spec.ControllerNamePrefix)
}

testNIC = manifests.NewNginxIngressController("nginx-ingress-controller", "nginxingressclass")
testNIC.Spec.DefaultSSLCertificate.Secret.Name = "validname"
testNIC.Spec.DefaultSSLCertificate.Secret.Namespace = "Invalid+@Namespace"
testNIC.Spec.DefaultSSLCertificate = &v1alpha1.DefaultSSLCertificate{
Secret: &v1alpha1.Secret{
Name: "validname",
Namespace: "Invalid+@Namespace",
},
}
lgr.Info("creating NginxIngressController with invalid Secret field")
if err := c.Create(ctx, testNIC); err == nil {
return fmt.Errorf("able to create NginxIngressController despite invalid Secret Namespace'%s'", testNIC.Spec.ControllerNamePrefix)
}

testNIC = manifests.NewNginxIngressController("nginx-ingress-controller", "nginxingressclass")
testNIC.Spec.DefaultSSLCertificate.Secret.Name = "validname"
testNIC.Spec.DefaultSSLCertificate.Secret.Namespace = ""
testNIC.Spec.DefaultSSLCertificate = &v1alpha1.DefaultSSLCertificate{
Secret: &v1alpha1.Secret{
Name: "validname",
Namespace: "",
},
}
lgr.Info("creating NginxIngressController with empty Secret field")
if err := c.Create(ctx, testNIC); err == nil {
return fmt.Errorf("able to create NginxIngressController despite missing Secret field'%s'", testNIC.Spec.ControllerNamePrefix)
Expand Down

0 comments on commit 7eff4ed

Please sign in to comment.