This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fix the network blip caused during network creation/deletion #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackfrancis Yes, this change depend on azure cni 1.0.7 |
Codecov Report
@@ Coverage Diff @@
## master #3438 +/- ##
=======================================
Coverage 55.85% 55.85%
=======================================
Files 105 105
Lines 15878 15878
=======================================
Hits 8868 8868
Misses 6265 6265
Partials 745 745 |
|
@madhanrm as Azure CNI 1.0.7 has merged, you can fix the conflict by simply removing the update to defaults.go |
|
@jackfrancis Done |
|
@PatrickLang for your eyes |
|
/lgtm |
PatrickLang
approved these changes
Jul 7, 2018
PatrickLang
approved these changes
Jul 7, 2018
|
@jackfrancis or @CecileRobertMichon can you merge? |
jackfrancis
approved these changes
Jul 7, 2018
PaulCharlton
added a commit
to ElementAnalytics/acs-engine
that referenced
this pull request
Jul 7, 2018
* 'master' of https://github.com/Azure/acs-engine: (74 commits) Fix the network blip caused during network creation/deletion (Azure#3438) Adding e2e sample for kubenet+wincni and adding DNS back to e2e tests (Azure#3429) openshift: quote all values going into yaml files and shell scripts (Azure#3443) Update clusterKeyVaultName for kv and sa (Azure#3440) Kubernetes: Azure CNI v1.0.7 (Azure#3433) account for nil (Azure#3442) higher timeout, more retries for dpkg -i (Azure#3441) Reenable azurefile test (Azure#3402) triage non-working KMS test implementation (Azure#3437) Kubernetes: install blobfuse during CSE (Azure#3401) Fix KMS in multi api-server (Azure#3430) update azure-npm to v0.0.4 (Azure#3426) Kubernetes E2E: optimized HPA test (Azure#3428) Starting Windows troubleshooting steps (Azure#3431) pin device plugin ds to only labelled nodes. Update device plugin version for 1.11 (Azure#3422) E2E cleanup: "acse-test-infrastructure" is too long (Azure#3425) Remove DenyEscalatingExec admission controller from default list (Azure#3423) long-term DNS livenessProbe tests for soak cluster (Azure#3424) Unit tests (Azure#3344) remove version check from k8s e2e (Azure#3419) ...
PaulCharlton
added a commit
to ElementAnalytics/acs-engine
that referenced
this pull request
Jul 7, 2018
* master: (566 commits) Fix the network blip caused during network creation/deletion (Azure#3438) Adding e2e sample for kubenet+wincni and adding DNS back to e2e tests (Azure#3429) openshift: quote all values going into yaml files and shell scripts (Azure#3443) Update clusterKeyVaultName for kv and sa (Azure#3440) Kubernetes: Azure CNI v1.0.7 (Azure#3433) account for nil (Azure#3442) higher timeout, more retries for dpkg -i (Azure#3441) Reenable azurefile test (Azure#3402) triage non-working KMS test implementation (Azure#3437) Kubernetes: install blobfuse during CSE (Azure#3401) Fix KMS in multi api-server (Azure#3430) update azure-npm to v0.0.4 (Azure#3426) Kubernetes E2E: optimized HPA test (Azure#3428) Starting Windows troubleshooting steps (Azure#3431) pin device plugin ds to only labelled nodes. Update device plugin version for 1.11 (Azure#3422) E2E cleanup: "acse-test-infrastructure" is too long (Azure#3425) Remove DenyEscalatingExec admission controller from default list (Azure#3423) long-term DNS livenessProbe tests for soak cluster (Azure#3424) Unit tests (Azure#3344) remove version check from k8s e2e (Azure#3419) ...
PatrickLang
pushed a commit
that referenced
this pull request
Jul 10, 2018
julienstroheker
pushed a commit
to julienstroheker/acs-engine
that referenced
this pull request
Jul 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The changes in this PR will fix the network blip/disconnection caused during the first POD creation (very much visible to customers logged into the windows node via RDP)
This change has a dependency with the latest azure cni 1.0.7 ( I can undo this change, if that is already being taken care of)
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: