Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Remove DenyEscalatingExec admission controller from default list #3423

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

lachie83
Copy link
Member

@lachie83 lachie83 commented Jul 5, 2018

We are removing this plugin by default for the following reasons:

  • It only impacts access via the Kubernetes API and without other measures enabled this can be easily circumvented.
  • It breaks upstream conformance tests.

If it's needed it can be enabled as part of the cluster definition.

Associated issues
kubernetes/kubernetes#64387
kubernetes/kubernetes#65271

@ghost ghost assigned lachie83 Jul 5, 2018
@ghost ghost added the in progress label Jul 5, 2018
@acs-bot acs-bot added the size/S label Jul 5, 2018
@jessfraz
Copy link
Contributor

jessfraz commented Jul 5, 2018

lgtm :)

@jackfrancis
Copy link
Member

For folks paying attention: the practical implication after this PR lands is for clusters that need DenyEscalatingExec is to explicitly state it in the cluster config (api model) from now on. E.g.:

<...>
    "kubernetesConfig": {
        "apiServerConfig": {
            "--admission-control": "<other stuff you need>,DenyEscalatingExec,<other stuff you need>"
    }
<...>

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Jul 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, lachie83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #3423 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3423   +/-   ##
======================================
  Coverage    55.9%   55.9%           
======================================
  Files         105     105           
  Lines       15855   15855           
======================================
  Hits         8864    8864           
  Misses       6249    6249           
  Partials      742     742

@jackfrancis jackfrancis merged commit 0acbf7c into Azure:master Jul 5, 2018
@ghost ghost removed the in progress label Jul 5, 2018
PaulCharlton added a commit to ElementAnalytics/acs-engine that referenced this pull request Jul 7, 2018
* 'master' of https://github.com/Azure/acs-engine: (74 commits)
  Fix the network blip caused during network creation/deletion (Azure#3438)
  Adding e2e sample for kubenet+wincni and adding DNS back to e2e tests (Azure#3429)
  openshift: quote all values going into yaml files and shell scripts (Azure#3443)
  Update clusterKeyVaultName for kv and sa (Azure#3440)
  Kubernetes: Azure CNI v1.0.7 (Azure#3433)
  account for nil (Azure#3442)
  higher timeout, more retries for dpkg -i (Azure#3441)
  Reenable azurefile test (Azure#3402)
  triage non-working KMS test implementation (Azure#3437)
  Kubernetes: install blobfuse during CSE (Azure#3401)
  Fix KMS in multi api-server (Azure#3430)
  update azure-npm to v0.0.4 (Azure#3426)
  Kubernetes E2E: optimized HPA test (Azure#3428)
  Starting Windows troubleshooting steps (Azure#3431)
  pin device plugin ds to only labelled nodes. Update device plugin version for 1.11 (Azure#3422)
  E2E cleanup: "acse-test-infrastructure" is too long (Azure#3425)
  Remove DenyEscalatingExec admission controller from default list (Azure#3423)
  long-term DNS livenessProbe tests for soak cluster (Azure#3424)
  Unit tests (Azure#3344)
  remove version check from k8s e2e (Azure#3419)
  ...
PaulCharlton added a commit to ElementAnalytics/acs-engine that referenced this pull request Jul 7, 2018
* master: (566 commits)
  Fix the network blip caused during network creation/deletion (Azure#3438)
  Adding e2e sample for kubenet+wincni and adding DNS back to e2e tests (Azure#3429)
  openshift: quote all values going into yaml files and shell scripts (Azure#3443)
  Update clusterKeyVaultName for kv and sa (Azure#3440)
  Kubernetes: Azure CNI v1.0.7 (Azure#3433)
  account for nil (Azure#3442)
  higher timeout, more retries for dpkg -i (Azure#3441)
  Reenable azurefile test (Azure#3402)
  triage non-working KMS test implementation (Azure#3437)
  Kubernetes: install blobfuse during CSE (Azure#3401)
  Fix KMS in multi api-server (Azure#3430)
  update azure-npm to v0.0.4 (Azure#3426)
  Kubernetes E2E: optimized HPA test (Azure#3428)
  Starting Windows troubleshooting steps (Azure#3431)
  pin device plugin ds to only labelled nodes. Update device plugin version for 1.11 (Azure#3422)
  E2E cleanup: "acse-test-infrastructure" is too long (Azure#3425)
  Remove DenyEscalatingExec admission controller from default list (Azure#3423)
  long-term DNS livenessProbe tests for soak cluster (Azure#3424)
  Unit tests (Azure#3344)
  remove version check from k8s e2e (Azure#3419)
  ...
julienstroheker pushed a commit to julienstroheker/acs-engine that referenced this pull request Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants