Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Fix KMS in multi api-server #3430

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Fix KMS in multi api-server #3430

merged 1 commit into from
Jul 6, 2018

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Jul 5, 2018

What this PR does / why we need it:
Fix KMS create key racing condition when there are multiple master nodes

Release note:

Fix KMS create key racing condition when there are multiple master nodes

Implementation details please refer to: Azure/kubernetes-kms#23
cc @khenidak @seanknox @juan-lee

@ghost ghost assigned ritazh Jul 5, 2018
@ghost ghost added the in progress label Jul 5, 2018
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit d456713 into Azure:master Jul 6, 2018
@ghost ghost removed the in progress label Jul 6, 2018
PaulCharlton added a commit to ElementAnalytics/acs-engine that referenced this pull request Jul 7, 2018
* 'master' of https://github.com/Azure/acs-engine: (74 commits)
  Fix the network blip caused during network creation/deletion (Azure#3438)
  Adding e2e sample for kubenet+wincni and adding DNS back to e2e tests (Azure#3429)
  openshift: quote all values going into yaml files and shell scripts (Azure#3443)
  Update clusterKeyVaultName for kv and sa (Azure#3440)
  Kubernetes: Azure CNI v1.0.7 (Azure#3433)
  account for nil (Azure#3442)
  higher timeout, more retries for dpkg -i (Azure#3441)
  Reenable azurefile test (Azure#3402)
  triage non-working KMS test implementation (Azure#3437)
  Kubernetes: install blobfuse during CSE (Azure#3401)
  Fix KMS in multi api-server (Azure#3430)
  update azure-npm to v0.0.4 (Azure#3426)
  Kubernetes E2E: optimized HPA test (Azure#3428)
  Starting Windows troubleshooting steps (Azure#3431)
  pin device plugin ds to only labelled nodes. Update device plugin version for 1.11 (Azure#3422)
  E2E cleanup: "acse-test-infrastructure" is too long (Azure#3425)
  Remove DenyEscalatingExec admission controller from default list (Azure#3423)
  long-term DNS livenessProbe tests for soak cluster (Azure#3424)
  Unit tests (Azure#3344)
  remove version check from k8s e2e (Azure#3419)
  ...
PaulCharlton added a commit to ElementAnalytics/acs-engine that referenced this pull request Jul 7, 2018
* master: (566 commits)
  Fix the network blip caused during network creation/deletion (Azure#3438)
  Adding e2e sample for kubenet+wincni and adding DNS back to e2e tests (Azure#3429)
  openshift: quote all values going into yaml files and shell scripts (Azure#3443)
  Update clusterKeyVaultName for kv and sa (Azure#3440)
  Kubernetes: Azure CNI v1.0.7 (Azure#3433)
  account for nil (Azure#3442)
  higher timeout, more retries for dpkg -i (Azure#3441)
  Reenable azurefile test (Azure#3402)
  triage non-working KMS test implementation (Azure#3437)
  Kubernetes: install blobfuse during CSE (Azure#3401)
  Fix KMS in multi api-server (Azure#3430)
  update azure-npm to v0.0.4 (Azure#3426)
  Kubernetes E2E: optimized HPA test (Azure#3428)
  Starting Windows troubleshooting steps (Azure#3431)
  pin device plugin ds to only labelled nodes. Update device plugin version for 1.11 (Azure#3422)
  E2E cleanup: "acse-test-infrastructure" is too long (Azure#3425)
  Remove DenyEscalatingExec admission controller from default list (Azure#3423)
  long-term DNS livenessProbe tests for soak cluster (Azure#3424)
  Unit tests (Azure#3344)
  remove version check from k8s e2e (Azure#3419)
  ...
julienstroheker pushed a commit to julienstroheker/acs-engine that referenced this pull request Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants