clear containers

[jessfraz]

What this PR does / why we need it: This adds the ability to define a container runtime for kubernetes. And adds clear-containers as a valid runtime.

Make containerRuntime configurable and add clear-containers as a valid runtime.

[jessfraz]

Updated and rebased on #1854

[jessfraz]

Okay so a few things:

If I set kubeletConfig to --container-runtime=remote then I still need to say what container runtime I want to use. And in the case of clear containers we only install clear-containers if the node allows nested virt, so say you want only the agents to be using clear-containers and the rest to not, then it easily just "works" out the box because it knows those nodes don't support nested virt. So all in all we still need a container runtime param.

[jackfrancis]

Is KUBELET_OPTS doing anything here?

[jessfraz]

Yes it is... it is being set when the runtime is set, unfortunately I was going to do this via the config file but the behavior of clear containers for how I usually setup clusters is the system nodes use docker and don't have nested virt enabled, and the agents all have nested virt so it sets --container-runtime=remote for only those nodes and not all of them

[jackfrancis]

Ah, sorry, didn't see it because gh was truncating the diff with all the whitespace fun! Whitespace has been made less fun, now I can see the setKubeletOpts function without clicking things.

[jackfrancis]

I also assume re-jiggering the operational queue by moving ensureRunCommandCompleted to come earlier is intentional?

[jessfraz]

ya I needed that to be done before installing other things.

[CecileRobertMichon]

Hey @jessfraz! Is there any way of making your implementation work without changing the order here? #1598 parallelized the custom script a few months back and we were able to get to sub 5 minutes deployments but this PR adds back an extra minute which means we're now at > 6 min deployments for 1 master clusters... Thoughts?

[jessfraz]

so the problem is this is installing things so I needed to make sure the other was no longer holding dpkg locks so this can install.... so maybe we can have an if runtime is clear-containers it takes forever and otherwise it will go back to the bottom and be fast?

I can make a PR if thats ok

[CecileRobertMichon]

Yeah I think that would work. Taking the extra minute for clear containers is definitely better than slowing down deployment for every cluster since most users will be using the default I think :) Thanks!

[jackfrancis]

lgtm, thanks again!

[jessfraz]

will make a pr :)

…

On Tue, Jan 16, 2018 at 8:03 PM, Cecile Robert-Michon < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In parts/k8s/kubernetesmastercustomscript.sh <#1945 (comment)>: > @@ -453,28 +644,39 @@ users: set -x } +ensureRunCommandCompleted Yeah I think that would work. Taking the extra minute for clear containers is definitely better than slowing down deployment for every cluster since most users will be using the default I think :) Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1945 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYNbON5V8tRlfV21nx9gCqi8Fl8rWt8ks5tLUbOgaJpZM4RGKt-> .

-- Jessie Frazelle 4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3 pgp.mit.edu <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>