This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 558
clear containers #1945
Merged
Merged
clear containers #1945
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
03e5826
clear-containers: add runtime to api and pass through parameters
jessfraz d78f2b2
clear-containers: add scripts
jessfraz 1df56b1
clear-containers: add example
jessfraz 1b21430
clear-containers: fix variables
jessfraz 43e95c5
clear-containers: add docs
jessfraz 23685c6
clear-containers: update install script
jessfraz 1d71f72
clear-containers: fix script
jessfraz c1c3fb5
clear-containers: update example
jessfraz 2c34f90
clear-containers: update features docs
jessfraz a3ed54d
clear-containers: make test linters happy
jessfraz e2f87f6
setKubeletOpts to work better with kubeconfig
jessfraz 7301963
whitespace cruft
jackfrancis e883f09
more whitespace fun
jackfrancis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
{ | ||
"apiVersion": "vlabs", | ||
"properties": { | ||
"orchestratorProfile": { | ||
"orchestratorType": "Kubernetes", | ||
"orchestratorRelease": "1.8", | ||
"kubernetesConfig": { | ||
"networkPolicy": "azure", | ||
"containerRuntime": "clear-containers", | ||
"etcdVersion": "3.1.10", | ||
"addons": [ | ||
{ | ||
"name": "tiller", | ||
"enabled" : false | ||
}, | ||
{ | ||
"name": "kubernetes-dashboard", | ||
"enabled" : false | ||
} | ||
] | ||
} | ||
}, | ||
"masterProfile": { | ||
"count": 1, | ||
"dnsPrefix": "", | ||
"vmSize": "Standard_D2_v2" | ||
}, | ||
"agentPoolProfiles": [ | ||
{ | ||
"name": "agentpool1", | ||
"count": 3, | ||
"vmSize": "Standard_D4s_v3", | ||
"availabilityProfile": "AvailabilitySet", | ||
"storageProfile": "ManagedDisks", | ||
"diskSizesGB": [1023] | ||
} | ||
], | ||
"linuxProfile": { | ||
"adminUsername": "azureuser", | ||
"ssh": { | ||
"publicKeys": [ | ||
{ | ||
"keyData": "" | ||
} | ||
] | ||
} | ||
}, | ||
"servicePrincipalProfile": { | ||
"clientId": "", | ||
"secret": "" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
KUBELET_OPTS
doing anything here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is... it is being set when the runtime is set, unfortunately I was going to do this via the config file but the behavior of clear containers for how I usually setup clusters is the system nodes use docker and don't have nested virt enabled, and the agents all have nested virt so it sets
--container-runtime=remote
for only those nodes and not all of themThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, didn't see it because gh was truncating the diff with all the whitespace fun! Whitespace has been made less fun, now I can see the
setKubeletOpts
function without clicking things.