Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(documentation): document noteCommitment vs noteHash #2127

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

suyash67
Copy link
Contributor

@suyash67 suyash67 commented Sep 8, 2023

resolves #1679

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@suyash67 suyash67 marked this pull request as ready for review September 8, 2023 11:42
@suyash67 suyash67 requested a review from jeanmon September 8, 2023 11:42
Copy link
Contributor

@jeanmon jeanmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

docs/docs/dev_docs/limitations/main.md Outdated Show resolved Hide resolved
@suyash67 suyash67 enabled auto-merge (squash) September 8, 2023 12:25
@suyash67 suyash67 merged commit 73b484f into master Sep 8, 2023
@suyash67 suyash67 deleted the sb/1679-document-note-naming branch September 8, 2023 12:27
PhilWindle pushed a commit that referenced this pull request Sep 8, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.5.2</summary>

##
[0.5.2](aztec-packages-v0.5.1...aztec-packages-v0.5.2)
(2023-09-08)


### Bug Fixes

* **build:** Config fixes for release please
([#2123](#2123))
([7b4f30d](7b4f30d))
* **build:** Don't include component in tag
([#2128](#2128))
([b588e3a](b588e3a))
* **build:** Updated version file
([#2131](#2131))
([30f9935](30f9935))
* Canary browser test transfer method
([#2126](#2126))
([a23b037](a23b037))
* File reference to canary docker-compose file
([#2124](#2124))
([13d3f16](13d3f16))
* Retry with -eu was suspect in retrospect
([#2110](#2110))
([7265c2a](7265c2a))


### Miscellaneous

* **build:** Enabled components in tags
([#2139](#2139))
([ccb38fb](ccb38fb))
* **build:** Fixed manifest
([#2122](#2122))
([91faa66](91faa66))
* **build:** Force a rebuild
([#2136](#2136))
([f26c9a0](f26c9a0))
* **build:** Reset version back
([#2132](#2132))
([750a757](750a757))
* **build:** Unify barretenberg releases with aztec-packages
([#2120](#2120))
([82823d8](82823d8))
* Delete broken bb Dockerfile.arm64-linux-gcc
([#2138](#2138))
([0f988b7](0f988b7))
* **documentation:** Document noteCommitment vs noteHash
([#2127](#2127))
([73b484f](73b484f)),
closes
[#1679](#1679)
* **master:** Release 0.6.0
([#2121](#2121))
([9bc8e11](9bc8e11))
</details>

<details><summary>barretenberg.js: 0.5.2</summary>

##
[0.5.2](barretenberg.js-v0.5.1...barretenberg.js-v0.5.2)
(2023-09-08)


### Miscellaneous

* **master:** Release 0.6.0
([#2121](#2121))
([9bc8e11](9bc8e11))
</details>

<details><summary>barretenberg: 0.5.2</summary>

##
[0.5.2](barretenberg-v0.5.1...barretenberg-v0.5.2)
(2023-09-08)


### Miscellaneous

* **master:** Release 0.6.0
([#2121](#2121))
([9bc8e11](9bc8e11))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Document confusing naming: noteHash == commitment
2 participants