fix: retry error safety #2110
Merged
fix: retry error safety #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
force-pushed
the
ad/fix-retry
branch
from
a1a97f9 to
aeb8c8d
Compare
|
Looks good, I'll let someone across the pond merge in case this somehow causes issues when people wake up |
spalladino
approved these changes
Sep 8, 2023
PhilWindle
pushed a commit
that referenced
this pull request
Sep 8, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.5.2</summary> ## [0.5.2](aztec-packages-v0.5.1...aztec-packages-v0.5.2) (2023-09-08) ### Bug Fixes * **build:** Config fixes for release please ([#2123](#2123)) ([7b4f30d](7b4f30d)) * **build:** Don't include component in tag ([#2128](#2128)) ([b588e3a](b588e3a)) * **build:** Updated version file ([#2131](#2131)) ([30f9935](30f9935)) * Canary browser test transfer method ([#2126](#2126)) ([a23b037](a23b037)) * File reference to canary docker-compose file ([#2124](#2124)) ([13d3f16](13d3f16)) * Retry with -eu was suspect in retrospect ([#2110](#2110)) ([7265c2a](7265c2a)) ### Miscellaneous * **build:** Enabled components in tags ([#2139](#2139)) ([ccb38fb](ccb38fb)) * **build:** Fixed manifest ([#2122](#2122)) ([91faa66](91faa66)) * **build:** Force a rebuild ([#2136](#2136)) ([f26c9a0](f26c9a0)) * **build:** Reset version back ([#2132](#2132)) ([750a757](750a757)) * **build:** Unify barretenberg releases with aztec-packages ([#2120](#2120)) ([82823d8](82823d8)) * Delete broken bb Dockerfile.arm64-linux-gcc ([#2138](#2138)) ([0f988b7](0f988b7)) * **documentation:** Document noteCommitment vs noteHash ([#2127](#2127)) ([73b484f](73b484f)), closes [#1679](#1679) * **master:** Release 0.6.0 ([#2121](#2121)) ([9bc8e11](9bc8e11)) </details> <details><summary>barretenberg.js: 0.5.2</summary> ## [0.5.2](barretenberg.js-v0.5.1...barretenberg.js-v0.5.2) (2023-09-08) ### Miscellaneous * **master:** Release 0.6.0 ([#2121](#2121)) ([9bc8e11](9bc8e11)) </details> <details><summary>barretenberg: 0.5.2</summary> ## [0.5.2](barretenberg-v0.5.1...barretenberg-v0.5.2) (2023-09-08) ### Miscellaneous * **master:** Release 0.6.0 ([#2121](#2121)) ([9bc8e11](9bc8e11)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No real reason for this script to have safety flags, and I suspect it was stopping retries early.