Fix binding related memory leaks #15485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes some memory leaks related to bindings.
What is the current behavior?
When a compiled binding has an
AvaloniaProperty
or a method in its path, and its source lives longer than the target, then the target is leaked. The same applies for an attached property through a reflection binding.What is the updated/expected behavior with this PR?
The bindings don't leak.
How was the solution implemented (if it's not obvious)?
Weak events have been used.
Unit tests have been added.
Of the 4 unit tests added,
CompiledBinding_To_InpcProperty_With_Alive_Source_Does_Not_Keep_Target_Alive
already passed and was added for comparison purposes. The 3 other tests fail without the changes in this PR.Fixed issues