fix: SelectingItemsControl Selection memory Leak #15446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
This was referenced Apr 23, 2024
MrJul
requested changes
Apr 24, 2024
| @@ -348,11 +348,11 @@ protected ISelectionModel Selection | |||
| } | |||
|
|
|||
| InitializeSelectionModel(_selection); | |||
|
|
|||
| if (_oldSelectedItems != SelectedItems) | |||
| var seletcedItems = SelectedItems; | |||
There was a problem hiding this comment.
Nit: typo, seletcedItems ⇒ selectedItems
|
|
||
| if (_oldSelectedItems != SelectedItems) | ||
| var seletcedItems = SelectedItems; | ||
| if (_oldSelectedItems.TryGetTarget(out var oldSelectedItems) || oldSelectedItems != seletcedItems) |
There was a problem hiding this comment.
This isn't equivalent to the comparison before: it will now always be true as long as we have an oldSelectedItems.
Suggested change
| if (_oldSelectedItems.TryGetTarget(out var oldSelectedItems) || oldSelectedItems != seletcedItems) | |
| _oldSelectedItems.TryGetTarget(out var oldSelectedItems); | |
| if (oldSelectedItems != selectedItems) |
|
You can test this PR using the following package version. |
MrJul
approved these changes
Apr 24, 2024
maxkatz6
added
the
backport-candidate-11.1.x
workgroupengineering
deleted the
fixes/Controls/SelectingItemsControl/Selection_Leak
branch
maxkatz6
pushed a commit
that referenced
this pull request
Apr 25, 2024
* fix: SelectingItemsControl * fix: Address review
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Avoid SelectingItemsControl memory leak
What is the current behavior?
When SelectingItemsControl or a derived control is bound to ObservableCollection, if you remove the selected item, the removed item will not be released from memory until there is a new _oldSelectedItem, this is because _oldSelectedItem holds a hard reference. If the collection contains only two items and you remove one, the removed item will never be released from memory.
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Instead of a hard reference using pre allocated WeakReference.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Part of #15443