Fixed memory leak in MethodCommandNode.cs #15123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
Suppressed by #15485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fix a memory leak in MethodCommandNode.cs that keeps controls in memory even when a window is closed.
What is the current behavior?
Binding to methods keeps the
sourceand the control in memory indefinitely.What is the updated/expected behavior with this PR?
No memory leaks
How was the solution implemented (if it's not obvious)?
I am not sure what's the lifecycle of
ExpressionNode, as it doesn't have anyDisposemethods.I changed subscription to
PropertyChangedto be based on weak reference.Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues