Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomic sites are not using WordPress.com translations for Gutenberg #29309

Closed
guicmazeredo opened this issue Dec 11, 2018 · 9 comments · Fixed by Automattic/jetpack#10982
Closed

Atomic sites are not using WordPress.com translations for Gutenberg #29309

guicmazeredo opened this issue Dec 11, 2018 · 9 comments · Fixed by Automattic/jetpack#10982
Assignees
@akirk
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug wp-admin

Comments

@guicmazeredo
Copy link

guicmazeredo commented Dec 11, 2018 •
edited by jeherve
Loading

Steps to reproduce

  1. Change a site's language to anything different from English (e.g. French).
  2. Edit an existing page/post or add a new one and add a block.
  3. Check the Blocks Settings Sidebar or the Block interface and you'll notice that not everything is translated.

What I expected

If Gutenberg blocks are translated on WordPress.com translations I expected to see the interface translated like we do for Simple Sites. It's pretty weird for a user that had everything translated on their simple site and once they get their site AT'd the blocks are not translated anymore.

What happened instead

It would be great to use WordPress.com translations on Atomic sites for consistency.

Context / Source

This was reported here:
p1544532027263400-slack-gutengroup-wpcomhappy
@guicmazeredo guicmazeredo added the [Goal] Gutenberg Working towards full integration with Gutenberg label Dec 11, 2018
@vindl vindl added [Pri] High Address as soon as possible after BLOCKER issues Atomic wp-admin labels Dec 11, 2018
@vindl
Copy link
Member

vindl commented Dec 11, 2018

@kwight I vaguely remember us fixing the translations for Calypsoify before. Any ideas why this might not be working for Atomic sites?

@kwight
Copy link
Contributor

kwight commented Dec 11, 2018

I don't know if Atomic/Jetpack was part of all that, I think more testing is needed first to narrow down exactly what parts are involved (eg. parts of the sidebar come from different API calls).

@vindl
Copy link
Member

vindl commented Dec 11, 2018

@akirk any ideas why this might be happening? Are there any known issues with wp-admin translations on Atomic sites?
/cc @Automattic/atomic

@jeherve
Copy link
Member

jeherve commented Dec 12, 2018

This seems to be a duplicate of #29244

@guicmazeredo
Copy link
Author

I'm not sure if they are related. It looks like the issue #29244 is related to the Jetpack blocks only and it was also occurring in Simple Sites. This one is happening with all blocks and is only occurring in Atomic sites.

@vindl vindl assigned vindl and akirk and unassigned vindl Dec 13, 2018
@akirk
Copy link
Member

akirk commented Dec 13, 2018

It looks like this patch for Core, scheduled for 5.0.2, will resolve this: https://core.trac.wordpress.org/ticket/45528

@akirk
Copy link
Member

akirk commented Dec 13, 2018

See p9o2xV-cH-p2 for more details.

@akirk akirk mentioned this issue Dec 16, 2018
Merged
@kriskarkoski kriskarkoski mentioned this issue Dec 16, 2018
Closed
jeherve pushed a commit to Automattic/jetpack that referenced this issue Dec 18, 2018
@akirk @jeherve
Asset CDN: Fix json translation loading (#10982)
8bb8a1b 
When the static asset CDN of Jetpack is loaded, the translations for Gutenberg don'tt load properly because the filename is generated for a wrong path.

Also fixes Automattic/wp-calypso#29309

This has been extensively discussed in https://core.trac.wordpress.org/ticket/45528

#### Changes proposed in this Pull Request:

* This implements the filter that has been introduced into Core.

#### Testing instructions:

Prequisit: WordPress 5.0.2(alpha) or trunk

1. Set your WordPress to another language than English.
2. Activate Jetpack Static Asset CDN.
3. Potentially add a filter to your WordPress if it's running trunk (see #10102)
4. Create a new post to open Gutenberg and observe broken translations.
5. Activate the patch: Translations should now load after a reload.

#### Proposed changelog entry for your changes:

* Fixes loading of the Block Editor UI translations when Static Asset CDN is used (requires WordPress 5.0.2)
@pratikawari28
Copy link

pratikawari28 commented Dec 19, 2018 •
edited
Loading

Got a user in chat reporting this issue in Japanese language: hc-8783842
It's an AT site - wellvill.com
Follow-up here : zen-1656223
Reference screenshot here : http://cld.wthms.co/Z3QIRR

Would someone mind taking another peek?

@jeherve
Copy link
Member

jeherve commented Dec 19, 2018

@pratikawari28 The issue will be fixed once both WordPress and Jetpack are updated (WP 5.0.2 on one hand, Jetpack 6.9 on the other).

While WP 5.0.2 should be released very soon, Jetpack 6.9 won't be released until January 10.

If the site owner would like to apply the work-around on their site sooner, they can do so thanks to the Jetpack Beta plugin and by searching and using this PR in Jetpack > Beta once the Beta plugin is installed:
Automattic/jetpack#10982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akirk akirk

Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug wp-admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Asset CDN: Fix json translation loading Automattic/jetpack
7 participants
@alisterscott @akirk @kwight @jeherve @vindl @guicmazeredo @pratikawari28