Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Display sidebar area in the same language as the site #28541

Closed
AtrumGeost opened this issue Nov 14, 2018 · 14 comments
Closed

Gutenberg: Display sidebar area in the same language as the site #28541

AtrumGeost opened this issue Nov 14, 2018 · 14 comments
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended wp-admin

Comments

@AtrumGeost
Copy link
Contributor

AtrumGeost commented Nov 14, 2018

Steps to reproduce

  1. Activate Gutenberg in Calypso
  2. Be sure that the Calypso and wp-admin languages are set to a non-English language like Spanish
  3. Add a new post using Calypso

What I expected

To see everything in Spanish (or my selected non-English language)

What happened instead

Only the content (left panel) is in the selected language. But the right sidebar is in English:

Browser / OS version

macOS Mojave 10.14.1 - Chrome Version 70.0.3538.102 (Official Build) (64-bit)

Screenshot / Video

screen shot 2018-11-14 at 10 13 14

Context / Source

User report: 8053969-hc

Was able to replicate that on a test site

@mlaetitia
Copy link

Got a user in chat reporting this issue in Swedish language: hc-8053240

Tested on a simple site (premium) in Portuguese (pt-pt) and was also able to replicate the issue (http://cld.wthms.co/y56PZf) .

@mlaetitia mlaetitia added the [Goal] Gutenberg Working towards full integration with Gutenberg label Nov 14, 2018
@kwight kwight added [Type] Bug When a feature is broken and / or not performing as intended [Pri] High Address as soon as possible after BLOCKER issues labels Nov 15, 2018
@mrfoxtalbot
Copy link

I got a user in chat today reporting this same issue.

@dcoleonline
Copy link
Contributor

dcoleonline commented Nov 19, 2018

Also reported in #1577485-zen

@gwwar
Copy link
Contributor

gwwar commented Nov 20, 2018

cc @Automattic/i18n for a look if we're behind on translations or this needs more framework help

For @Automattic/lannister folks investigating, a core fetch api middleware may have broken again.

@gwwar gwwar added the wp-admin label Nov 20, 2018
@cecoates
Copy link

Got another one. User actually didn't mind the new editor, but struggled with it being in English.

2408837-hc

@correliebre
Copy link

Also reported today in chat: #8202694-hc
And replicated on my own site.

@akirk
Copy link
Member

akirk commented Nov 21, 2018

I had a quick look and the problem comes from the fact that we don't have a gutenberg textdomain on translate.wordpress.com, hence no translations are provided from the PHP.

Still trying to think of the best solution here. Either:

  • create a dedicated project on translate.wordpress.com for Gutenberg strings and deploy them through our i18n-deploy process.
  • use the WordPress.org language packs and check them into wpcom-i18n.

We then need to load either of them on the php side.

Other opinions, maybe @yoavf?

@liviopv
Copy link

liviopv commented Nov 23, 2018

another in #7991740-hc

@akirk even though the strings don't have their own project, we can see some Gutenberg-related strings and translate them (@eduardozulian and I have made the Guten-strings 100% translated to pt-br this week), but they simply don't get deployed.

@tijosh
Copy link

tijosh commented Nov 23, 2018

Another in #1590036-zen. (Italian)

@samiff
Copy link
Contributor

samiff commented Nov 27, 2018

User reported in 4674539-hc (for Deutsch)

@serabi
Copy link

serabi commented Nov 27, 2018

User reported in 7871537-hc (for Russian)

@gwwar
Copy link
Contributor

gwwar commented Nov 28, 2018

This should be fixed by D21305-code and D21408-code, written by @mmtr and @akirk

@gwwar gwwar closed this as completed Nov 28, 2018
@sdixon194
Copy link
Contributor

Just had a report of a user in Russian still seeing English text in the sidebar: http://cld.wthms.co/hfWGbM

1648366-zen

Would someone mind taking another peek?

@sdixon194 sdixon194 reopened this Dec 15, 2018
@kriskarkoski
Copy link
Contributor

@sdixon194 It looks like this is an Atomic site, which has a separate issue opened here: #29309

Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended wp-admin
Projects
None yet
Development

No branches or pull requests