Lazy Images: Skip images with data-skip-lazy attribute

[ebinnion]

Per a request from a hosting partner and a community member, add the ability to skip lazy loading of images that have the data-skip-lazy attribute.

Changes proposed in this Pull Request:

• Do not lazy load images that have data-skip-lazy attribute

Is this a new feature or does it add/remove features to an existing part of Jetpack?

• This is a new feature for an existing module.

Testing instructions:

• Checkout branch
• Ensure Lazy Images is active
• Create a post with an image
• Modify image's HTML to include data-skip-lazy="1"
• Publish post then load post
• Check source of image, and ensure that it does not have the jetpack-lazy-image--handled class nor any other lazy attributes.

For example, there are two images in the source here. The top on was not lazy loaded but the bottom one was.

Proposed changelog entry for your changes:

• Update lazy images module to skip images with the data-skip-lazy attribute

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against f4d0f59

[jeherve]

I'd have 2 questions about this:

• Isn't the jetpack_lazy_images_skip_image_with_atttributes filter meant to do just that today?
• We're already past the code freeze and in the Beta period for Jetpack 8.2; would it be acceptable to ship this in Jetpack 8.3 instead?

[ebinnion]

Isn't the jetpack_lazy_images_skip_image_with_atttributes filter meant to do just that today?

That's a good question. Yes, users and third-party developers could use that filter to exclude images based on an attribute. But, the purpose of adding this attribute is to standardize how users and third-party theme/developers can exclude images from being lazily loaded.

Other plugins use some combination of the skip-lazy class or the data-skip-lazy attribute. So, the goal is for all plugins to support both.

Of note, there's a core marketing push for this around this as well.

would it be acceptable to ship this in Jetpack 8.3 instead?

Yes sir.

[dereksmart]

TIL how to use @dataProvider! Thanks for adding the tests.