Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of "if" checking to prevent errors #14592

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Optimization of "if" checking to prevent errors #14592

merged 1 commit into from
Feb 13, 2020

Conversation

DenisJunio
Copy link
Contributor

@DenisJunio DenisJunio commented Feb 6, 2020 •
edited
Loading

An error occurred if one was added when finalizing the order that does not have a product ID (item without product page)

Fixes #

Changes proposed in this Pull Request:

  • Optimization of the "if" check to ensure that the variable "$product" is an object

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • No

Testing instructions:

  • Add an item (item without product page) to the cart and finalize an order.

Proposed changelog entry:

  • WooCommerce Analytics - Check that the $product variable is of the correct type (WC_Product).

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 3c4e141

@DenisJunio DenisJunio marked this pull request as ready for review February 6, 2020 20:05
@DenisJunio DenisJunio requested a review from a team February 6, 2020 20:05
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] WooCommerce Analytics labels Feb 10, 2020
@jeherve jeherve added this to the 8.3 milestone Feb 10, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 10, 2020
jeherve
jeherve approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This seems like a good way to consolidate things. 👍

@kraftbj kraftbj changed the title [Jetpack WooCommerce Analytics] Optimization of "if" checking to prevent errors Optimization of "if" checking to prevent errors Feb 13, 2020
@kraftbj kraftbj merged commit 8cb27fa into Automattic:master Feb 13, 2020
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 13, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14592
ba6af79
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees
No one assigned
Labels
[Feature] WooCommerce Analytics [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.
5 participants
@DenisJunio @jetpackbot @jeherve @kraftbj @matticbot