Lazy Images: Skip images with data-skip-lazy attribute

Automattic · Jan 31, 2020 · f4d0f59 · f4d0f59
1 parent 18e4626
commit f4d0f59
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/modules/lazy-images/lazy-images.php b/modules/lazy-images/lazy-images.php
@@ -202,6 +202,10 @@ static function process_image_attributes( $attributes ) {
 			return $attributes;
 		}
 
+		if ( isset( $attributes['data-skip-lazy'] ) ) {
+			return $attributes;
+		}
+
 		/**
 		 * Allow plugins and themes to conditionally skip processing an image via its attributes.
 		 *

diff --git a/tests/php/modules/lazy-images/test_class.lazy-images.php b/tests/php/modules/lazy-images/test_class.lazy-images.php
@@ -271,6 +271,34 @@ function get_dont_process_images_with_classes_data() {
 		);
 	}
 
+	/**
+	 * @dataProvider get_dont_process_images_with_skip_lazy_data_attribute_data
+	 */
+	function test_dont_process_images_with_skip_lazy_data_attribute( $input, $should_skip = true ) {
+		$instance = Jetpack_Lazy_Images::instance();
+		$output = $instance->add_image_placeholders( $input );
+
+		if ( $should_skip ) {
+			$this->assertNotContains( 'srcset="placeholder.jpg"', $output );
+		} else {
+			$this->assertContains( 'srcset="placeholder.jpg"', $output );
+		}
+	}
+
+	function get_dont_process_images_with_skip_lazy_data_attribute_data() {
+		return array(
+			'skip_lazy_attr_only' => array(
+				'<img src="image.jpg" srcset="medium.jpg 1000w, large.jpg 2000w" data-skip-lazy/>',
+			),
+			'skip-lazy-attr-true' => array(
+				'<img src="image.jpg" srcset="medium.jpg 1000w, large.jpg 2000w" data-skip-lazy="true"/>',
+			),
+			'skip-lazy-attr-1' => array(
+				'<img src="image.jpg" srcset="medium.jpg 1000w, large.jpg 2000w" data-skip-lazy="1"/>',
+			),
+		);
+	}
+
 	/**
 	 * @dataProvider get_should_skip_image_with_blacklisted_class_data
 	 */