Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parentheses from list table view counts when Calypsofying. #13110

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

jeffstieler
Copy link
Contributor

Fixes Automattic/wc-calypso-bridge#458.

Original issue:

When viewing a post listing page, like orders, the type totals shown at the top have styling in place to emulate the <Count /> component of calypso. But inside the count "bubble" the numbers are displayed inside parenthesis, which looks quite odd. Seems like we should just do one or the other.

order-counts-parens

Changes proposed in this Pull Request:

  • String replaces the list table counts from (10) to 10.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • No

Testing instructions:

  • Go to the Posts listing
  • Enable "calypsoify" by appending ?calypsoify=1 to the URL
  • Verify there are no parentheses in the Post table view filters (All, Published, etc)

Proposed changelog entry for your changes:

  • Changelog change probably isn't necessary

@jeffstieler jeffstieler added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Feature] Calypsoify labels Jul 22, 2019
@jeffstieler jeffstieler requested review from timmyc and a team July 22, 2019 20:02
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: August 6, 2019.
Scheduled code freeze: July 30, 2019

Generated by 🚫 dangerJS against 82ea828

@jeherve jeherve added this to the 7.6 milestone Jul 29, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 29, 2019
@jeherve jeherve merged commit bdef451 into master Jul 29, 2019
@jeherve jeherve deleted the fix/bridge-458-parens-in-count branch July 29, 2019 08:31
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jul 29, 2019
jeherve added a commit that referenced this pull request Jul 29, 2019
jeherve added a commit that referenced this pull request Jul 30, 2019
* Add initial changelog / testing list changes for 7.6

* Update stable tag to 7.5.3

* changelog: add #12957

* Changelog: add #12932

* Changelog: add #12867

* Changelog: add #12823

* changelog: add #12969

* changelog: add #13012

* changelog: add #12974

* Changelog: add #13059

* Changelog: add #13079

* Changelog: add #12924

* changelog: add #12954

* Changelog: add #12959

* Changelog: add #12977

* Changelog: add #12830

* Changelog: add #12926

* Changelog: add #12958

* Changelog: add #12999

* Changelog: add #13077

* Changelog: add #13083

* Changelog: add #13087

* Changelog: add #13110

* Changelog: add #13116

* Changelog: add #13117

* Changelog: add #12821

* Changelog: add #13120

* changelog: add #13139

* Changelog: add #13143

* Changelog: add #13147

* Testing list: add section about sync
jeherve added a commit that referenced this pull request Jul 30, 2019
* Add initial changelog / testing list changes for 7.6

* Update stable tag to 7.5.3

* changelog: add #12957

* Changelog: add #12932

* Changelog: add #12867

* Changelog: add #12823

* changelog: add #12969

* changelog: add #13012

* changelog: add #12974

* Changelog: add #13059

* Changelog: add #13079

* Changelog: add #12924

* changelog: add #12954

* Changelog: add #12959

* Changelog: add #12977

* Changelog: add #12830

* Changelog: add #12926

* Changelog: add #12958

* Changelog: add #12999

* Changelog: add #13077

* Changelog: add #13083

* Changelog: add #13087

* Changelog: add #13110

* Changelog: add #13116

* Changelog: add #13117

* Changelog: add #12821

* Changelog: add #13120

* changelog: add #13139

* Changelog: add #13143

* Changelog: add #13147

* Testing list: add section about sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Counts, parens inside <Count />
4 participants