Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

At a Glance Upgrade Banners - changed them to grow vertically #13087

Merged
merged 1 commit into from
Jul 19, 2019
Merged

At a Glance Upgrade Banners - changed them to grow vertically #13087

merged 1 commit into from
Jul 19, 2019

Conversation

MichaelArestad
Copy link
Contributor

@MichaelArestad MichaelArestad commented Jul 19, 2019 •
edited
Loading

Fixes #13036

Changes proposed in this Pull Request:

  • The Upgrade banners in DashItems will now grow vertically

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Not a new feature

Testing instructions:

  • Create a new Jetpack site using this link
  • Activate Akismet
  • Connect Jetpack (go through flow and return to wp-admin)
  • Go to the Jetpack Dashboard.

Before

image

After

image

Proposed changelog entry for your changes:

  • No changelog needed

@MichaelArestad MichaelArestad added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Jul 19, 2019
@MichaelArestad MichaelArestad requested review from crunnells and a team July 19, 2019 16:33
@MichaelArestad MichaelArestad self-assigned this Jul 19, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: August 6, 2019.
Scheduled code freeze: July 30, 2019

Generated by 🚫 dangerJS against 2091445

@jeherve jeherve added the Admin Page React-powered dashboard under the Jetpack menu label Jul 19, 2019
@jeherve jeherve added this to the 7.6 milestone Jul 19, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 19, 2019
jeherve
jeherve approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Merge when ready.

It's worth noting, however, that the icons don't always display nicely in IE11:

image

This may be worth addressing in another PR.

@MichaelArestad
Copy link
Contributor Author

This may be worth addressing in another PR.

For sure. Thanks for the review.

@jeherve jeherve merged commit ef8c68d into master Jul 19, 2019
@jeherve jeherve deleted the update/at-a-glance-banner-height branch July 19, 2019 21:14
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jul 19, 2019
jeherve added a commit that referenced this pull request Jul 29, 2019
@jeherve
Changelog: add #13087
8e40647
jeherve added a commit that referenced this pull request Jul 30, 2019
@jeherve
7.6: running changelog (#12940)
f1d6377 
* Add initial changelog / testing list changes for 7.6

* Update stable tag to 7.5.3

* changelog: add #12957

* Changelog: add #12932

* Changelog: add #12867

* Changelog: add #12823

* changelog: add #12969

* changelog: add #13012

* changelog: add #12974

* Changelog: add #13059

* Changelog: add #13079

* Changelog: add #12924

* changelog: add #12954

* Changelog: add #12959

* Changelog: add #12977

* Changelog: add #12830

* Changelog: add #12926

* Changelog: add #12958

* Changelog: add #12999

* Changelog: add #13077

* Changelog: add #13083

* Changelog: add #13087

* Changelog: add #13110

* Changelog: add #13116

* Changelog: add #13117

* Changelog: add #12821

* Changelog: add #13120

* changelog: add #13139

* Changelog: add #13143

* Changelog: add #13147

* Testing list: add section about sync
jeherve added a commit that referenced this pull request Jul 30, 2019
@jeherve
7.6: running changelog (#12940)
37aabd8 
* Add initial changelog / testing list changes for 7.6

* Update stable tag to 7.5.3

* changelog: add #12957

* Changelog: add #12932

* Changelog: add #12867

* Changelog: add #12823

* changelog: add #12969

* changelog: add #13012

* changelog: add #12974

* Changelog: add #13059

* Changelog: add #13079

* Changelog: add #12924

* changelog: add #12954

* Changelog: add #12959

* Changelog: add #12977

* Changelog: add #12830

* Changelog: add #12926

* Changelog: add #12958

* Changelog: add #12999

* Changelog: add #13077

* Changelog: add #13083

* Changelog: add #13087

* Changelog: add #13110

* Changelog: add #13116

* Changelog: add #13117

* Changelog: add #12821

* Changelog: add #13120

* changelog: add #13139

* Changelog: add #13143

* Changelog: add #13147

* Testing list: add section about sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@crunnells crunnells Awaiting requested review from crunnells

Assignees

@MichaelArestad MichaelArestad

Labels
Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.6
Development

Successfully merging this pull request may close these issues.

At a Glance: Align cards so they form a seamless grid
4 participants
@MichaelArestad @jetpackbot @jeherve @matticbot