Mobile: Hide edit post link in content

[donpark]

Changes proposed in this Pull Request:

Adds an edit_post_link filter to return empty string if request is from an WordPress mobile app.

Hides edit post link in post content if client is a WordPress mobile app.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

No. This is a manual sync PR for D29686-code.

See trac link in the patch for more detail on the issue this PR and the mentioned patch addresses.

Testing instructions:

1. Use a browser that lets you change User-Agent easily. Chrome, for example, has User agent settings under Three Dot menu > More tools > Network conditions.
2. View a post you have edit permission to using Chrome browser with default User-Agent.
3. Verify that Edit link is displayed.

4. Add wp-iphone/1.0 or wp-android to User-Agent string and refresh the page.

5. Verify that Edit link is no longer displayed.

Proposed changelog entry for your changes:

Hide edit post link in post content if client is a WordPress mobile app.

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against f9a90bc

[jeherve]

Do you think it would make sense to shorten this into something like:

if ( Jetpack_User_Agent_Info::is_mobile_app() ) {
	add_filter( 'edit_post_link', '__return_empty_string' );
}

Should we also consider moving this out of the Minileven module, so it can be applied regardless of the theme you are using, and even if the mobile theme feature / module is not enabled on your site?

[donpark]

Do you think it would make sense to shorten this into something like:

if ( Jetpack_User_Agent_Info::is_mobile_app() ) {
	add_filter( 'edit_post_link', '__return_empty_string' );
}

Ha. Yes, init-per-request mindset is still a stranger to me.

Should we also consider moving this out of the Minileven module, so it can be applied regardless of the theme you are using, and even if the mobile theme feature / module is not enabled on your site?

Can you suggest the ideal place for this code? I just followed where wp-mobile.php function names pointed to.

[jeherve]

Can you suggest the ideal place for this code? I just followed where wp-mobile.php function names pointed to.

It may be best to place it in class.jetpack.php. That file is already way too big, but it's really the only place where it fits well right now. You'll actually find other edit post link changes in there (look for point_edit_post_links_to_calypso) :)

[donpark]

Result of my test against my wpsandbox.me site using the latest:

Without this patch:

With this patch:

[jeherve]

This works well for me. 👍