Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

deps: update vue-good-table #1494

Merged
merged 20 commits into from
Oct 31, 2019
Merged

deps: update vue-good-table #1494

merged 20 commits into from
Oct 31, 2019

Conversation

dated
Copy link
Contributor

@dated dated commented Oct 1, 2019

Summary

Updates vue-good-table to 2.18.0 and fixes the table components along with it, stopping the wallet from freezing.

This PR also:

  • fixes sorting by voted delegate in the wallets table
  • fixes sorting in the transactions table

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Oct 1, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Medium Less than 256 lines changed. label Oct 1, 2019
@dated dated changed the title deps: update vue-good-table [WIP] deps: update vue-good-table Oct 1, 2019
@dated
Copy link
Contributor Author

dated commented Oct 1, 2019

 PASS  __tests__/unit/pages/Profile/ProfileAll.spec.js (9.735s)
  pages > ProfileAll
    √ should render component (58ms)
    aggregatedBalances
      √ should aggregate the sum of the balances of all profiles by network (21ms)
      when there are profiles with the same wallets
        √ should include those wallets only 1 time (21ms)
      when the Ledger has wallets on the current network
        √ should include their balances (24ms)
        when they are included as non-Ledger wallets
          √ should include those wallets only 1 time (18ms)
    totalBalances
      √ should return the sum of balances per network, using their symbols, sorted by quantity descently (17ms)
      when the Ledger has wallets on the current network
        √ should include their balances, sorted by quantity descently (14ms)
    profileBalance
      √ should return the formatted balance of a profile, using the network symbol (18ms)

all tests pass locally 🤔

@dated
Copy link
Contributor Author

dated commented Oct 1, 2019

FAIL __tests__/unit/pages/Profile/ProfileAll.spec.js
  ● pages > ProfileAll › totalBalances › should return the sum of balances per network, using their symbols, sorted by quantity descently

    expect(received).toEqual(expected) // deep equality

    - Expected
    + Received

      Array [
    -   "m 500.150909",
    -   "d 0.5201",
    -   "o 0.1219",
    +   "m 500.00",
    +   "d 1.00",
    +   "o 0.00",
      ]

      141 |     it('should return the sum of balances per network, using their symbols, sorted by quantity descently', () => {
      142 |       wrapper = mountPage()
    > 143 |       expect(wrapper.vm.totalBalances).toEqual([
          |                                        ^
      144 |         'm\xa0500.150909',
      145 |         'd\xa00.5201',
      146 |         'o\xa00.1219'

      at Object.toEqual (__tests__/unit/pages/Profile/ProfileAll.spec.js:143:40)

any idea how 225a404 might be causing the rounding issue when run through github actions @faustbrian @alexbarnsley?

@dated dated changed the title [WIP] deps: update vue-good-table deps: update vue-good-table Oct 1, 2019
@alexbarnsley
Copy link
Member

I think there's a problem with pagination 🤔 I can't seem to get past page 2, but the pagination buttons don't seem to change (e.g. it thinks it's still on page 1)

@dated
Copy link
Contributor Author

dated commented Oct 16, 2019

Let me check, any specific table or all of em?

@alexbarnsley
Copy link
Member

I noticed on transaction and delegate list, so possibly all of them? 🤔

@dated
Copy link
Contributor Author

dated commented Oct 16, 2019

Most likely, will fix ASAP..

@dated
Copy link
Contributor Author

dated commented Oct 16, 2019

should be fixed now @alexbarnsley

@alexbarnsley
Copy link
Member

thanks! I'll be back to checking on PRs in the next few days

@alexbarnsley alexbarnsley added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Oct 31, 2019
@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Oct 31, 2019
@ghost
Copy link

ghost commented Oct 31, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@alexbarnsley alexbarnsley merged commit 9cf8b56 into ArkEcosystem:develop Oct 31, 2019
@ghost
Copy link

ghost commented Oct 31, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the deps/vue-good-table branch October 31, 2019 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Medium Less than 256 lines changed. Status: Member Approved The pull request has been approved by a member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants