This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: left aligned sortable table headers #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessiodf
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
added
Complexity: Low
ghost
mentioned this pull request
alexbarnsley
approved these changes
Nov 19, 2019
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
ghost
added
the
Status: Member Approved
alexbarnsley
added
the
Bounty: Tier 4
|
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1494 broke table formatting for left-aligned headers that used the
text-leftclass if the column contained numerical data and that column was being used to sort the data in the table. This is because that PR forces sorted headers to be flexboxes withjustify-content: flex-end(sincevgt-right-alignis automatically applied if the column contains numerical data).This fixes it by overriding this with
justify-content: flex-startif the header also has thetext-leftclass. This approach was chosen as it mirrors the existing.vgt-table th.vgt-right-align.text-centerCSS rule for centre-aligned headers.Although the wallet itself doesn't seem to use left-aligned sortable headers for numerical data, some plugins, including my own, will need this as plugins can't define their own CSS classes and
vue-good-tabledoes not permit us to specify our own styles, only classes.Checklist