This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: ledger transaction amount on confirm modal #1572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #1562, except for transactions created for a Ledger wallet. Transactions now use a
totalAmount
property to display on the confirmation modal (and also for sorting). In the future, we will remove this property and look at doing it a better way, so we don't need to worry about assigning that property whenever a transaction is created.I'll look at tests at the same time as updating to not require
totalAmount
.Checklist