Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: ledger transaction amount on confirm modal #1572

Merged
merged 3 commits into from
Dec 9, 2019

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Dec 5, 2019

Summary

Relates to #1562, except for transactions created for a Ledger wallet. Transactions now use a totalAmount property to display on the confirmation modal (and also for sorting). In the future, we will remove this property and look at doing it a better way, so we don't need to worry about assigning that property whenever a transaction is created.

I'll look at tests at the same time as updating to not require totalAmount.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Dec 5, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@35cf534). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1572   +/-   ##
==========================================
  Coverage           ?   45.52%           
==========================================
  Files              ?      274           
  Lines              ?     6832           
  Branches           ?     1337           
==========================================
  Hits               ?     3110           
  Misses             ?     3561           
  Partials           ?      161
Impacted Files Coverage Δ
...ransaction/TransactionForm/TransactionFormVote.vue 12.35% <ø> (ø)
...TransactionForm/TransactionFormSecondSignature.vue 15% <ø> (ø)
...actionForm/TransactionFormDelegateRegistration.vue 14.28% <ø> (ø)
...action/TransactionForm/TransactionFormTransfer.vue 32.02% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35cf534...43ee5fe. Read the comment docs.

@luciorubeens luciorubeens merged commit a7433fd into develop Dec 9, 2019
@luciorubeens luciorubeens deleted the fix/ledger-transaction-amount-on-confirmation branch December 9, 2019 10:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants