[Proposal] Introduce ResilienceStrategyBuilderBase #1236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
One thing I wasn't a big fan of was the duplications of extensions for non-reactive strategies such as
Timeout
orRateLimiter
.In this PR I am introducing
ResilienceStrategyBuilderBase
class. The extensibility author can use is to target extensions that work for both generic and non-generic strategies.This way full set of extensions are always exposed for both generic and non-generic builders and there are no duplications.
The extension bellow will be visible for both builder types:
I have dropped a bunch of duplicate extensions.
What do you think about this idea?
Confirm the following