Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ResilienceStrategyBuilder #1240

Merged
merged 1 commit into from
May 30, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 30, 2023

Details on the issue fix or feature implementation

Follow-up of #1236. I realized we can drop some more unnecessary duplications in each builder by leveraging extension methods for basic scenarios.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 30, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #1240 (855b005) into main (045cec0) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   82.81%   82.79%   -0.02%     
==========================================
  Files         263      264       +1     
  Lines        6103     6096       -7     
  Branches      966      966              
==========================================
- Hits         5054     5047       -7     
  Misses        844      844              
  Partials      205      205              
Flag Coverage Δ
linux 82.79% <100.00%> (-0.02%) ⬇️
macos 82.79% <100.00%> (-0.02%) ⬇️
windows 82.79% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Polly.Core/ResilienceStrategyBuilder.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategyBuilder.cs 100.00% <ø> (ø)
...lly.Core/Strategy/ResilienceStrategyBuilderBase.cs 100.00% <ø> (ø)
...ack/FallbackResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
...ging/HedgingResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
.../Polly.Core/ResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 2b7fbf2 into main May 30, 2023
@martintmk martintmk deleted the mtomka/cleanup-resiliencestrategybuilder branch May 30, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants