Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the creation of outcome invokers #1237

Merged
merged 5 commits into from
May 30, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 30, 2023

Details on the issue fix or feature implementation

Adding CreateInvoker methods to ResilienceStrategyBuilderContext to simplify the creation and taking advantage of automatic type resolution.

No public API changes.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 30, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #1237 (6845288) into main (63853e2) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   82.84%   82.91%   +0.07%     
==========================================
  Files         262      262              
  Lines        6115     6141      +26     
  Branches      964      966       +2     
==========================================
+ Hits         5066     5092      +26     
  Misses        844      844              
  Partials      205      205              
Flag Coverage Δ
linux 82.91% <100.00%> (+0.07%) ⬆️
macos 82.91% <100.00%> (+0.07%) ⬆️
windows 82.91% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rcuitBreakerResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
...ack/FallbackResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
...ging/HedgingResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/ResilienceStrategyBuilder.TResult.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceStrategyBuilder.cs 100.00% <100.00%> (ø)
.../Retry/RetryResilienceStrategyBuilderExtensions.cs 100.00% <100.00%> (ø)
src/Polly.Core/Strategy/EventInvoker.cs 100.00% <100.00%> (ø)
src/Polly.Core/Strategy/GeneratorInvoker.cs 100.00% <100.00%> (ø)
src/Polly.Core/Strategy/PredicateInvoker.cs 100.00% <100.00%> (ø)
....Core/Strategy/ResilienceStrategyBuilderContext.cs 100.00% <100.00%> (ø)

@martintmk
Copy link
Contributor Author

This PR will also help with #1236 where I can drop additional duplications.

@martintmk martintmk enabled auto-merge (squash) May 30, 2023 09:32
@martintmk martintmk disabled auto-merge May 30, 2023 09:32
@martintmk martintmk merged commit 141bd0a into main May 30, 2023
@martintmk martintmk deleted the mtomka/cleanup-invokers branch May 30, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants