Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a new bookmark either the auto-assigned labels are added or the 'Bookmark labels' dialog is shown #1105

Closed
Tracked by #1187
agrogers opened this issue May 29, 2021 · 9 comments

Comments

@agrogers
Copy link
Contributor

agrogers commented May 29, 2021

I can see where being able to auto-assign labels would be good - say when recording sermon notes or focusing on a particular topic. But my workflow has rarely been like that.

I always add a bookmark, then click it, then click the label, and now select the label from the new label dialog (or create a new label). I never leave a bookmark label set to 'Unlabelled'.

What I think should happen is:

  1. If there are labels set to automatically assign to new bookmarks, those labels should be assigned and nothing else is done
  2. If there are no labels set to automatically be assigned, then the 'Unlabelled' label is assigned and the new Bookmark Labels dialog should be displayed (see below). The user can then choose the label from the quick lists or open the full list to create a new one.

image

@agrogers
Copy link
Contributor Author

Hi @tuomas2 . This is probably the last thing left on my personal list of features to make the assigning of labels pretty much perfect. Did you see this one?

@tuomas2
Copy link
Contributor

tuomas2 commented Jun 19, 2021

I can implement, but not in prio list

@agrogers
Copy link
Contributor Author

The way this issue streamlines the bookmarking process (see #1172) makes me think we should...
Include this feature in v3.4.

@tuomas2
Copy link
Contributor

tuomas2 commented Jun 25, 2021

Added to prio list. But does not need strings so not 'that urgent'

@tuomas2
Copy link
Contributor

tuomas2 commented Jul 8, 2021

(those commits should have gone towards #1249 actually)

@tuomas2
Copy link
Contributor

tuomas2 commented Jul 8, 2021

Should it be "Bookmark modal" + "Bookmark labels" both opened automatically, so that when you end, you need to close both of them? Or just "Bookmark labels", such that you need to re-open bookmark if you want to have it opened?

@agrogers
Copy link
Contributor Author

agrogers commented Jul 8, 2021

Yay! This change will make me smile for weeks.

Only show the one dialog - Bookmark Labels - I think. Reopening would be needed to add a note (occasionally needed by me) or check the Info (never needed by me).

If #1169 gets implemented then the Note icon will get you back there. Possibly should also include an Info icon on that form which would do exactly what you asked about.
image

@tuomas2 tuomas2 closed this as completed in cd421cf Jul 8, 2021
@tuomas2
Copy link
Contributor

tuomas2 commented Jul 8, 2021

I decided to go with my 1st option, for simplicity and perhaps bit more logical perhaps to me.

@agrogers
Copy link
Contributor Author

agrogers commented Jul 8, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants