Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default bookmarks & labels #1172

Closed
1 task
tuomas2 opened this issue Jun 23, 2021 · 24 comments
Closed
1 task

Default bookmarks & labels #1172

tuomas2 opened this issue Jun 23, 2021 · 24 comments

Comments

@tuomas2
Copy link
Contributor

tuomas2 commented Jun 23, 2021 •
edited
Loading

  1. A set of labels. Perhaps those labels can be called 'Blue', 'Red',' Green' etc. So when a user goes to add a bookmark there are already a number of labels they can choose from - they dont have to create any.
  2. Maybe some labels already assigned - perhaps to Genesis 1:1 so that the study pad functionality can be used.
  • these we could implement in 3.4. As an example of topical label there could be "Salvation" topic and few bookmarks in it.

So new default labels

  • Red
  • Green
  • Blue
  • Underline
  • Salvation

Feel free to suggest verses to be bookmarked with label "Salvation" (in addition to Joh 3:16)
@tuomas2 tuomas2 mentioned this issue Jun 23, 2021
Closed
@tuomas2
Copy link
Contributor Author

tuomas2 commented Jun 24, 2021

Feel free to suggest verses to be bookmarked with label "Salvation" (in addition to Joh 3:16)

@timbze
Copy link
Contributor

timbze commented Jun 24, 2021

Some possibilities (you can pick and choose)
Salvation

  • John 3:3
  • Titus 3:3-7 (too long?)
  • Romans 3:23-24
  • Romans 4:3
  • 1Tim 1:15
  • Eph 2:8-9

@agrogers
Copy link
Contributor

agrogers commented Jun 24, 2021 •
edited
Loading

I would not add a label to too many more verses than this because the bookmarks can only be removed one by one. Although I imagine not too many people would disagree with this label choice, I still wouldnt want to make it too difficult for them to remove what we have forced on to them.

My reason for proposing some default labels was to try and reduce the barriers to highlighting a verse in some particular color. I think this is especially important for new users.

What I noticed in YouVersion (and others apps) was you could do this by:

  1. Click once on a verse.
  2. Choose your color (from a list of 14 colors). Verse is now highlighted.

In And Bible (without existing labels) the process is:

  1. Long click on the verse to select a word (not so intuitive for a user)
  2. Choose 'Bookmark'
  3. Choose 'Verses'
  4. Click again on the verse which now has a default highlight (not so intuitive)
  5. Click on the Unlabelled label (not so intuitive)
  6. Click 'Select or edit labels...' button
  7. Click the plus button to add a label
  8. Enter the details of the label (with lots of possible options which might be a bit scary for a new user)
  9. Click back
  10. Click back
  11. Close the bookmark labels dialog
  12. Now you can see your highlighted verse.

With some preexisting, default colored labels already set up AND already added to the Recent Labels list (or Favourite list) we can reduce the number of steps to 6. I still think that is too many steps, especially for users coming from other apps.

That is why I proposed

If all of those were implemented a new user could highlight a single verse in 2 steps without losing any of the bookmarking power that And Bible already has. In fact, those proposals are for the most part not adding new features - they are simply getting to existing functionality in a much more direct manner.

@agrogers agrogers mentioned this issue Jun 25, 2021
Closed
@agrogers agrogers mentioned this issue Jul 3, 2021
Closed
@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 14, 2021

Some possibilities (you can pick and choose)
Salvation

  • John 3:3
  • Titus 3:3-7 (too long?)
  • Romans 3:23-24
  • Romans 4:3
  • 1Tim 1:15
  • Eph 2:8-9

I guess I must add also Gen.1.1 and Joh.3.16 because those are the possible landing pages. Joh 3.16 is default if downloaded bible has NT. Gen.1.1 is otherwise.

@agrogers
Copy link
Contributor

10 commandments perhaps? I know some of us like Ray Comfort.
Is 6:3 - the most important verse in the Bible (according to me)
Rev 4:8 - second most important verse :-)

Whatever verses we choose, having the bible open to one of them would be good.

But again, bookmarks can only be deleted one by one. As long as we are ok with the implications of that.

@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 14, 2021

Bit weird that they all will go under label "salvation", but we can't do much about it at this point :-P

@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 14, 2021

Partly implemented in 8a831e2

@agrogers
Copy link
Contributor

Were you adding some other default labels like 'Red' and 'Yellow' etc? If so you could place some under those. Surely colors I could translate myself via Google Translate?

@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 14, 2021 •
edited
Loading

red, green and blue, underline. I think they are a good start for a new user.

@timbze
Copy link
Contributor

timbze commented Jul 15, 2021

I don't think the migration should happen for existing users. Except maybe if they have no bookmarks or labels yet?

Trying to put myself in current user's shoes I think it feels intrusive to be upgraded with bookmarks when I already have bookmarks

@agrogers
Copy link
Contributor

agrogers commented Jul 15, 2021 via email

@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 15, 2021

I see. I also ended up removing them...

tuomas2 added a commit that referenced this issue Jul 15, 2021
@tuomas2
Add example labels and bookmarks only if there are no existing labels…
ec37d08 
… in db #1172
tuomas2 added a commit that referenced this issue Jul 15, 2021
@tuomas2
Add example bookmarks only if there are no existing bookmarks in db #…
741cf57 
…1172
tuomas2 added a commit that referenced this issue Jul 15, 2021
@tuomas2
Fix typo in 10 commandments bookmark ref #1172
cfa1eb3
@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 15, 2021

Because of bug fixed in last commit, you now have one ridiculously long bookmark spanning from exodus chapter 2 to chapter 17. :-D It's cool to notice that AB still performs pretty fast even when handling that bookmark.

@agrogers
Copy link
Contributor

agrogers commented Jul 15, 2021 via email

@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 15, 2021

I think this is now fully implemented.

@tuomas2 tuomas2 closed this as completed Jul 15, 2021
@agrogers
Copy link
Contributor

agrogers commented Jul 15, 2021 via email

@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 15, 2021 

if no manually created labels exist in db,
   create highlight and salvation labels. 
    if no bookmarks are created in db, 
        create example bookmarks too. 
if there exists workspaces
   mark created highlight labels as favourite in all of them (if created labels)
else
   create 2 workspaces with highlight labels as favourite

@agrogers
Copy link
Contributor

agrogers commented Jul 15, 2021 via email

@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 15, 2021

Are there some examples of two bookmarks on the one verse? And are the labels both underline and normal style? It would be great to demonstrate the highlighting of a particular word but that can only be done if we know the version.

No... I'll re-open and see this again. We could highlight some random words maybe in landing verses.

@tuomas2 tuomas2 reopened this Jul 15, 2021
@agrogers
Copy link
Contributor

agrogers commented Jul 15, 2021 via email

@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 15, 2021

I think only thing pending for videos is icons :-)

@agrogers
Copy link
Contributor

agrogers commented Jul 15, 2021 via email

@tuomas2
Copy link
Contributor Author

tuomas2 commented Jul 22, 2021

Looks now like this:

Screenshot_20210722_163145

@tuomas2 tuomas2 changed the title Default labels Default bookmarks & labels Jul 22, 2021
tuomas2 added a commit that referenced this issue Jul 22, 2021
@tuomas2
Improve default bookmarks (#1172)
e6d41f5
@tuomas2 tuomas2 closed this as completed Jul 22, 2021
@agrogers
Copy link
Contributor

agrogers commented Jul 22, 2021 via email

@timbze timbze mentioned this issue Oct 10, 2021
Open
@tuomas2 tuomas2 moved this to Closed in Tuomas' project board Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Tuomas' project board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tuomas2 @agrogers @timbze