Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for initial target dialog when a bible window is clicked #1169

Closed
Tracked by #1187
agrogers opened this issue Jun 19, 2021 · 17 comments
Closed
Tracked by #1187

Proposal for initial target dialog when a bible window is clicked #1169

agrogers opened this issue Jun 19, 2021 · 17 comments
Labels
Prio: Minor Status: Preliminary Type: Feature

Comments

@agrogers
Copy link
Contributor

agrogers commented Jun 19, 2021 •
edited
Loading

This is a more mature version of #1165
Also needs #1188

I noticed that we now have three different dialogs that are displayed depending on what we click on in a bible window. They are described in the image below. I am not sure this is a good idea. I know exactly what is happening because I have helped design this :) But I am sure this could be a bit disconcerting for a user.

I think a better option is that the user is always taken to a form that looks the same (or almost the same) wherever they click in a bible window. Further explanation is in the image.

  1. The only real change to the existing form structure is the addition of the Info icon so the user can navigate to the main bookmark dialog (top left).
  2. I have added a Speak icon here too. Maybe other things that are verse specific down the track.
  3. What I like most about this approach is that a) the user sees pretty much the same thing whatever verse he clicks on and b) almost all the functionality which is hidden behind a long press and/or multiple menus is now really easily accessible and, more importantly, really visible.
  4. The long-press option can remain as is with the exception that when a bookmark is selected it takes you directly to the 'verse-action' dialog (bottom right)
    AndBible Suggestions-click target
@tuomas2
Copy link
Contributor

tuomas2 commented Jun 19, 2021

Also footnotes and crossreferences create modals.

@agrogers
Copy link
Contributor Author

True, I don't see those much. I think they and strong's numbers and morph codes can be left just as they are.

@agrogers
Copy link
Contributor Author

As I mentioned elsewhere, this proposal is very related to the how the new labeling system works. So if it is to be implemented, i would say included it now so that users are not having to relearn something new in the future. I also think this proposal is a fairly significant simplification of how the user interacts with labels making it a worthy inclusion.

Include this feature in v3.4.

@agrogers agrogers mentioned this issue Jun 25, 2021
Closed
@tuomas2 tuomas2 mentioned this issue Jun 25, 2021
Closed
5 tasks
@agrogers
Copy link
Contributor Author

#1188 tries to address the link issue.

@agrogers agrogers mentioned this issue Jul 8, 2021
Closed
@tuomas2
Copy link
Contributor

tuomas2 commented Jul 8, 2021

I believe this is also fully implemented as of #1162

@tuomas2 tuomas2 closed this as completed Jul 8, 2021
@agrogers
Copy link
Contributor Author

We seemed to have reverted back to the original target for a verse with an existing bookmark. It's shown in the first column in the first image above.

I think it was working differently a few days ago.

The issue remains the same - now I can't get to the operations I might want on a verse - share, compare etc.

Was that a deliberate change?

@agrogers agrogers reopened this Jul 10, 2021
@tuomas2
Copy link
Contributor

tuomas2 commented Jul 11, 2021

We seemed to have reverted back to the original target for a verse with an existing bookmark. It's shown in the first column in the first image above.

I think it was working differently a few days ago.

The issue remains the same - now I can't get to the operations I might want on a verse - share, compare etc.

Was that a deliberate change?

If a visible bookmark highlight is clicked and there's only 1 bookmark, it will open the bookmark. It will work for all actions similar way. It will see all the actions, see if there's only one action with top priority, it will do the action immediately. If there are more, it will show the ambiguous selection dialog.

I think it works as it should.

@agrogers
Copy link
Contributor Author

agrogers commented Jul 11, 2021 via email

@agrogers
Copy link
Contributor Author

agrogers commented Jul 11, 2021 via email

@tuomas2
Copy link
Contributor

tuomas2 commented Jul 11, 2021

Perhaps we should lower the priority for whole verse bookmarks (especially underline style?)... But it was quite bugging me that I couldn't single-tap to bookmark dialog from my bookmarks.

@tuomas2
Copy link
Contributor

tuomas2 commented Jul 11, 2021 

export const EventPriorities = {
    HIDDEN_BOOKMARK: 0,
    VISIBLE_BOOKMARK: 5,
    FOOTNOTE: 15,
    STRONGS_DOTTED: 5,

    // "link-style"
    EXTERNAL_LINK: 10,
    REFERENCE: 10,
    STRONGS_LINK: 10,
}

@tuomas2
Copy link
Contributor

tuomas2 commented Jul 11, 2021

if priority is 0 then it will show the ambiguous selection dialog even if there's only one item

@agrogers
Copy link
Contributor Author

agrogers commented Jul 11, 2021 via email

@tuomas2
Copy link
Contributor

tuomas2 commented Jul 11, 2021

What do you use the bookmark dialog for? It's kind of a dialog that I like the look of (especially the bottom few lines ;-) but I rarely need. - It doesn't show all the labels (they fade out) - I still have to click the notepad to make a note. - It shows me the selected part of the verse but I could already see that before I clicked. - It shows me when the bookmark was created but I never need that. - I do like seeing all the names of the labels in the study pad list. But I can get that info from the summarised form. So I am not sure why I would use it. Oh, if it has a note attached it is useful. That's the only thing I can think of. Am I missing something?

I guess it's most annoying if there's note that I want to see. If that is the case, perhaps I could try again to put bookmarks to 0 prio and only put note icon to have higher prio so that by clicking note icon directly user gets to bookmark. I'll test again and see how it feels..

@agrogers
Copy link
Contributor Author

Yeah, I understand. Can we include a way to get back to the verse action dialog? Maybe use this button with a new icon?

IMG_20210711_224251.jpg

tuomas2 added a commit that referenced this issue Jul 12, 2021
@tuomas2
Adjust priorities again #1169
9472e61
tuomas2 added a commit that referenced this issue Jul 12, 2021
@tuomas2
Add open my notes button and improve layout #1169
bf60dd0
@tuomas2
Copy link
Contributor

tuomas2 commented Jul 15, 2021

Yeah, I understand. Can we include a way to get back to the verse action dialog? Maybe use this button with a new icon?

I'd like not to confuse bookmark modal with ambiguous selection modal.

@tuomas2
Copy link
Contributor

tuomas2 commented Jul 15, 2021

This is anyway now changed back so that ambiguous modal is shown if bookmark is clicked (unless clicking marker icon).

@tuomas2 tuomas2 closed this as completed Jul 15, 2021
@timbze timbze mentioned this issue Sep 3, 2021
Closed
@tuomas2 tuomas2 moved this to Closed in Tuomas' project board Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Prio: Minor Status: Preliminary Type: Feature
Projects
Tuomas' project board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tuomas2 @agrogers