Irmaku/wc generator issue #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue updates the bug report template to clarify some of the content when form is completed. Changes to be committed: modified: .github/ISSUE_TEMPLATE/settings.yml newfile: .github/ISSUE_TEMPLATE/bug_report.yml newfile: .github/ISSUE_TEMPLATE/feature_request.yml newfile: .github/ISSUE_TEMPLATE/general-support.yml deleted: .github/ISSUE_TEMPLATE/bug_report.md deleted: .github/ISSUE_TEMPLATE/feature_request.md
Remove the dependency from the wc-generator and update the documentation to support this transition. Retrofitting legacy elements is not a priority as there will be a time overlap while the population upgrades to the next version. Changes to be committed: modified: template/package.json modified: docs/readme.md deleted: docs/focus-visible.md
Change to be committed: modified: .npmignore
|
|
blackfalcon
requested changes
Apr 24, 2023
This was
linked to
issues
Apr 24, 2023
Change to modified: modified: .github/ISSUE_TEMPLATE/bug-report.yml
This was
linked to
issues
Apr 25, 2023
Closed
blackfalcon
requested changes
Apr 25, 2023
Change to modified: modified: template/src/[namespace]-[name].js modified: template/package.json
Change to modified: modified: package-lock.json modified: .npmignore modified: npmignore.temp
Change to modified: newfile: template/tsconfig.json
Change to be Committed: modified: template/package.json modified: template/scripts/postCss.js deleted: template/babel.config.js deleted: template/index.html deleted: template/rollup.config.js deleted: template/scripts/removeNonRemPlugin.js deleted: template/src/es5.js deleted: template/src/style-fixed.scss newfile: template/rollup.config.mjs
Change to be Committed: modified: template/.github/settings.yml newfile: template/.github/ISSUE_TEMPLATE/bug_report.yml newfile: template/.github/ISSUE_TEMPLATE/feature_request.yml newfile: template/.github/ISSUE_TEMPLATE/general-support.yml deleted: template/.github/ISSUE_TEMPLATE/bug_report.md deleted: template/.github/ISSUE_TEMPLATE/feature_request.md deleted: template/.github/ISSUE_TEMPLATE/general-support.md
Change to be Commited: newfile: template/README.md
Change to be Committed: modified: template/index.js modified: template/package.json modified: template/demo/index.html modified: template/docs/partials/demo.md modified: template/src/[namespace]-[name].js modified: template/test/[namespace]-[name].test.js deleted: template/README.md
irma-kurnia-alaska
force-pushed
the
irmaku/WCGeneratorIssue
branch
from
b9da0d3 to
ed867e2
Compare
blackfalcon
previously requested changes
Apr 27, 2023
blackfalcon
force-pushed
the
irmaku/WCGeneratorIssue
branch
2 times, most recently
from
2e78fbc to
370cea4
Compare
Change to be Committed: modified: componentDocs/partials/usage/bundleUse.md modified: componentDocs/partials/usage/bundleUseModBrowsers.md modified: template/docs/partials/demo.md
This commit will add all suggested items from the code review.
This commit will address the following updates: 1. Update to support Node 18 2. Update dependencies 3. Update template to support latest Chalk 4. Update to latest version of Husky 5. Update template to support Sass override 6. Update src template to use Lit 2.0 7. Remove demo build process Changes to be committed: modified: .github/workflows/testPublish.yml modified: package-lock.json modified: package.json deleted: template/demo/style.scss modified: template/package.json renamed: template/packageScripts/postinstall.js -> template/packageScripts/postinstall.mjs modified: template/scripts/generateDocs.js modified: template/scripts/postCss.js renamed: template/scripts/pre-commit.js -> template/scripts/pre-commit.mjs modified: template/src/[namespace]-[name].js modified: template/src/style.scss
BREAKING CHANGE: This commit will remove all functionality related to the use of AuroLabs as a concept. Changes to be committed: modified: bin/generate.js modified: componentDocs/README.md modified: componentDocs/README_v4.md deleted: componentDocs/partials/labsDisclaimer.md deleted: template/.github/settings__labs.yml modified: template/scripts/generateDocs.js
Changes to be committed: modified: template/.github/settings.yml
Changes to be committed: modified: template/.stylelintrc
Changes to be committed: modified: template/scripts/generateDocs.js
Changes to be committed: modified: demo/index.html
Changes to be committed: modified: template/package.json
Changes to be committed: modified: template/package.json
Changes to be committed: modified: componentDocs/README.md modified: componentDocs/README_v4.md
Changes to be committed: modified: template/demo/index.html
blackfalcon
force-pushed
the
irmaku/WCGeneratorIssue
branch
3 times, most recently
from
60221af to
24a51ab
Compare
Changes to be committed: modified: template/.npmignore.temp modified: template/.gitignore.temp
Changes to be committed: modified: template/package.json
blackfalcon
force-pushed
the
irmaku/WCGeneratorIssue
branch
from
24a51ab to
9673434
Compare
1 task
This commit reverts the following commit - commit 36ee012 Changes to be committed: modified: template/scripts/generateDocs.js
jason-capsule42
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #181 , #294 , #330 , #337 , #345 , #374 , #382, #377, #339, #375, #381, #274, #345, #381, #320, #385
Summary:
...
Type of change:
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team