Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IE support #181

Closed
blackfalcon opened this issue Aug 14, 2021 · 0 comments
Closed

Remove IE support #181

blackfalcon opened this issue Aug 14, 2021 · 0 comments
Assignees
Labels
Type: Feature New Feature

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Aug 14, 2021

Is your feature request related to a problem? Please describe.

We are no longer required to support Internet Explorer, so any and all tech included with the WC-Generator to support IE should be removed.

Describe the solution you'd like

See the following commit

Exit criteria

This issue will be considered closed once all the specified es5 supporting resources have been removed from the project. The validate a demo component should be generated from the generator and when built will not have any processes or generated code that is required to support IE11 and below.

This includes re-processes CSS to support variable fallbacks and fixed sizes. There should be no es5-generated bundles or references to them in the documentation. All npm dependencies that are no longer required should be removed from the project.

Additional context

Currently with the generator, there is a build issue due to a poorly supported dependency.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: @aurodesignsystem/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"^3.20.6" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@"^0.65.2 || ^1.0.0 || ^2.0.0" from [email protected]
npm ERR! node_modules/rollup-plugin-minify-html-literals
npm ERR!   dev rollup-plugin-minify-html-literals@"^1.2.6" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/dalesande/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/dalesande/.npm/_logs/2023-04-20T19_21_14_669Z-debug-0.log

This commit removes this dependency altogether.

While the reduction of es5 resources greatly reduces the bundle size of elements, not having HTML template literals minified does bloat the weight of an element.

A possible option is to look into a better-supported rollup-plugin-minify-template-literals dependency.

@blackfalcon blackfalcon added the Type: Feature New Feature label Aug 14, 2021
@blackfalcon blackfalcon self-assigned this Aug 14, 2021
@blackfalcon blackfalcon mentioned this issue Aug 14, 2021
7 tasks
@blackfalcon blackfalcon changed the title Generator: remove IE suport [linked]: remove IE support Aug 18, 2021
@blackfalcon blackfalcon removed their assignment Aug 18, 2021
@blackfalcon blackfalcon changed the title [linked]: remove IE support Remove IE support Aug 18, 2021
@blackfalcon blackfalcon added this to the v4.0-rc milestone Sep 3, 2021
@settings settings bot removed the generator label Sep 23, 2021
@blackfalcon blackfalcon added the not-reviewed Issue has not been reviewed by Auro team members label Nov 10, 2021
@braven112 braven112 removed the not-reviewed Issue has not been reviewed by Auro team members label Dec 21, 2021
@blackfalcon blackfalcon added the not-reviewed Issue has not been reviewed by Auro team members label Jan 20, 2023
@blackfalcon blackfalcon removed breaking-change not-reviewed Issue has not been reviewed by Auro team members labels Apr 20, 2023
irma-kurnia-alaska pushed a commit that referenced this issue Apr 25, 2023
Change to be Committed:

modified: template/package.json
modified: template/scripts/postCss.js
deleted: template/babel.config.js
deleted: template/index.html
deleted: template/rollup.config.js
deleted: template/scripts/removeNonRemPlugin.js
deleted: template/src/es5.js
deleted: template/src/style-fixed.scss
newfile: template/rollup.config.mjs
@irma-kurnia-alaska irma-kurnia-alaska linked a pull request Apr 25, 2023 that will close this issue
3 tasks
irma-kurnia-alaska pushed a commit that referenced this issue Apr 26, 2023
Change to be Committed:

modified: template/package.json
modified: template/scripts/postCss.js
deleted: template/babel.config.js
deleted: template/index.html
deleted: template/rollup.config.js
deleted: template/scripts/removeNonRemPlugin.js
deleted: template/src/es5.js
deleted: template/src/style-fixed.scss
newfile: template/rollup.config.mjs
@blackfalcon blackfalcon removed a link to a pull request May 3, 2023
3 tasks
blackfalcon pushed a commit that referenced this issue May 9, 2023
Change to be Committed:

modified: template/package.json
modified: template/scripts/postCss.js
deleted: template/babel.config.js
deleted: template/index.html
deleted: template/rollup.config.js
deleted: template/scripts/removeNonRemPlugin.js
deleted: template/src/es5.js
deleted: template/src/style-fixed.scss
newfile: template/rollup.config.mjs
blackfalcon pushed a commit that referenced this issue May 9, 2023
# [4.0.0](v3.17.4...v4.0.0) (2023-05-09)

### Bug Fixes

* automatically generate TypeScript description files ([dea833e](dea833e))
* generator: update CDN reference [#382](#382) ([cb65617](cb65617))
* **reference:** update to use [@AuroDesignSystem](https://github.com/aurodesignsystem) [#345](#345) ([1a628fa](1a628fa))
* **sec:** remove inefficient regular expression [#357](#357) ([c726423](c726423))
* update docs on issue template ([acd5531](acd5531))

### Features

* address general issues to get build working ([a4eba9a](a4eba9a))
* **typescript:** add typescript support ([a2d48e0](a2d48e0))

### Performance Improvements

* **ignore:** update configs [#385](#385) ([ea52043](ea52043))
* **labs:** remove auroLabs functionality [#339](#339) ([f32d69f](f32d69f))
* remove deprecated stylelint rules [#381](#381) ([568016e](568016e))
* remove IE support [#181](#181) ([c8543b3](c8543b3))
* remove polyfill focus visible ([6b68814](6b68814))
* **review:** add all suggested updates ([268e86a](268e86a))
* **settings:** update labels [#377](#377) ([c2cccf7](c2cccf7))
* **watch:** add apiExamples to generate docs [#320](#320) ([32c005f](32c005f))
* **windows:** update dev script [#274](#274) ([5efb6f8](5efb6f8))

### Reverts

* .npmignore and update .npmignore.temp ([85a135f](85a135f))
* return removed regex [#357](#357) ([08e2957](08e2957))

### BREAKING CHANGES

* **labs:** This commit will remove all functionality related
to the use of AuroLabs as a concept.

Changes to be committed:
modified:   bin/generate.js
modified:   componentDocs/README.md
modified:   componentDocs/README_v4.md
deleted:    componentDocs/partials/labsDisclaimer.md
deleted:    template/.github/settings__labs.yml
modified:   template/scripts/generateDocs.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

No branches or pull requests

4 participants