Changing API test error code from 500 to 400 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acampos1916
requested review from
cyattilakiss and
msilvagarcia
as code owners
cyattilakiss
approved these changes
Sep 7, 2020
Merged
acampos1916
added a commit
that referenced
this pull request
Sep 10, 2020
* [PW-2473]: Shopware review fixes and remove 3DS2 image size (#7) * Shopware review fixes and remove 3DS2 image size * Indentation fixes * Hardcode 3DS image size * Revert hardcode 3DS image size * [PW-2562] Adjustments for phpcs (#9) * Fixes and removing phpcs exclude patterns in favor of specific rules suppression * New phpcs version and ignore/disable sniffs * Adjusting copyright comment * Update composer.json (#31) To correctly install the plugin via composer, the module directory needs to be renamed to 'AdyenPayment'. * Fix #19 PW-2601 Update completed state (#34) * Fix #22 PW-2743 Show error on 404 (#35) Shows error message when 404 is returned from Test button. This means the plugin is not active. * PW-2603 remove customer id from shopperinfo payload (#33) Co-authored-by: Wanne Van Camp <[email protected]> * Fixing Yandex logo (#40) * Improve exception logging (#37) Fix #23 PW-2747 * Fixes #15 Handle offer_closed notification (#39) * Fixes #15 Handle offer_closed notification * PW-2748 Tabs -> spaces * Fixes #18 PW-2600 Catch exception during backend Test (#38) * Fixes #18 PW-2600 Catch exception during backend Test * PW-2600 Tabs to spaces * PW-2804 Save form before test (#36) Saves the config before the test is ran. Fix #24 * PW-2565 Make paymentsmethod cache configurable (#43) Adds configuration option to make caching of /paymentmethods call configurable. Co-authored-by: Ángel Campos <[email protected]> Fixes #26 * PW-2505 Distinquish fields of test and live (#44) * PW-2505 Distinquish fields of test and live * PW-2505 Remove debug lines * Improve labels Co-authored-by: Ángel Campos <[email protected]> Co-authored-by: Marcos Garcia <[email protected]> Co-authored-by: Ángel Campos <[email protected]> * Fixes #13 PW-2748 Add event to order restore (#42) * Localizing changelog (#49) * Feature/change refund function (#48) * Save successful psp reference to PaymentInfo * Fixes #17 Use succesfull notification for refunds * Changing API test error code from 500 to 400 (#52) * Fixing changelog * 1.5.0 version bump * Adding N/A to houseNumberOrName in Components/Payload/Providers/ShopperInfoProvider.php Co-authored-by: maxwellpowers <[email protected]> Co-authored-by: Rune Laenen <[email protected]> Co-authored-by: Wanne Van Camp <[email protected]> Co-authored-by: Wanne Van Camp <[email protected]> Co-authored-by: Rune Laenen <[email protected]> Co-authored-by: Marcos Garcia <[email protected]>
wannevancamp
pushed a commit
to wannevancamp/adyen-shopware5
that referenced
this pull request
Sep 25, 2020
* develop: (21 commits) Only send mail after succesful payment (Adyen#46) Adding N/A to houseNumberOrName in Components/Payload/Providers/ShopperInfoProvider.php 1.5.0 version bump Fixing changelog Changing API test error code from 500 to 400 (Adyen#52) Feature/change refund function (Adyen#48) Localizing changelog (Adyen#49) Fixes Adyen#13 PW-2748 Add event to order restore (Adyen#42) PW-2505 Distinquish fields of test and live (Adyen#44) PW-2565 Make paymentsmethod cache configurable (Adyen#43) PW-2804 Save form before test (Adyen#36) Fixes Adyen#18 PW-2600 Catch exception during backend Test (Adyen#38) Fixes Adyen#15 Handle offer_closed notification (Adyen#39) Improve exception logging (Adyen#37) Fixing Yandex logo (Adyen#40) PW-2603 remove customer id from shopperinfo payload (Adyen#33) Fix Adyen#22 PW-2743 Show error on 404 (Adyen#35) Fix Adyen#19 PW-2601 Update completed state (Adyen#34) Update composer.json (Adyen#31) [PW-2562] Adjustments for phpcs (Adyen#9) ... # Conflicts: # plugin.xml
acampos1916
added a commit
that referenced
this pull request
Sep 30, 2020
* [PW-2473]: Shopware review fixes and remove 3DS2 image size (#7) * Shopware review fixes and remove 3DS2 image size * Indentation fixes * Hardcode 3DS image size * Revert hardcode 3DS image size * [PW-2562] Adjustments for phpcs (#9) * Fixes and removing phpcs exclude patterns in favor of specific rules suppression * New phpcs version and ignore/disable sniffs * Adjusting copyright comment * Update composer.json (#31) To correctly install the plugin via composer, the module directory needs to be renamed to 'AdyenPayment'. * Fix #19 PW-2601 Update completed state (#34) * Fix #22 PW-2743 Show error on 404 (#35) Shows error message when 404 is returned from Test button. This means the plugin is not active. * PW-2603 remove customer id from shopperinfo payload (#33) Co-authored-by: Wanne Van Camp <[email protected]> * Fixing Yandex logo (#40) * Improve exception logging (#37) Fix #23 PW-2747 * Fixes #15 Handle offer_closed notification (#39) * Fixes #15 Handle offer_closed notification * PW-2748 Tabs -> spaces * Fixes #18 PW-2600 Catch exception during backend Test (#38) * Fixes #18 PW-2600 Catch exception during backend Test * PW-2600 Tabs to spaces * PW-2804 Save form before test (#36) Saves the config before the test is ran. Fix #24 * PW-2565 Make paymentsmethod cache configurable (#43) Adds configuration option to make caching of /paymentmethods call configurable. Co-authored-by: Ángel Campos <[email protected]> Fixes #26 * PW-2505 Distinquish fields of test and live (#44) * PW-2505 Distinquish fields of test and live * PW-2505 Remove debug lines * Improve labels Co-authored-by: Ángel Campos <[email protected]> Co-authored-by: Marcos Garcia <[email protected]> Co-authored-by: Ángel Campos <[email protected]> * Fixes #13 PW-2748 Add event to order restore (#42) * Localizing changelog (#49) * Feature/change refund function (#48) * Save successful psp reference to PaymentInfo * Fixes #17 Use succesfull notification for refunds * Changing API test error code from 500 to 400 (#52) * Fixing changelog * 1.5.0 version bump * Adding N/A to houseNumberOrName in Components/Payload/Providers/ShopperInfoProvider.php * Only send mail after succesful payment (#46) * Only send mail after succesful payment * Fixes #12 Tabs to spaces * Fix indentation * Fix indentation Co-authored-by: Marcos Garcia <[email protected]> Co-authored-by: Ángel Campos <[email protected]> * #54 cronjobs not running (#55) Add missing service registration * add redirect data to payments request (#56) Co-authored-by: Wanne Van Camp <[email protected]> * 1.5.1 changelog Co-authored-by: maxwellpowers <[email protected]> Co-authored-by: Rune Laenen <[email protected]> Co-authored-by: Wanne Van Camp <[email protected]> Co-authored-by: Wanne Van Camp <[email protected]> Co-authored-by: Rune Laenen <[email protected]> Co-authored-by: Marcos Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.