Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The plugin does not handle the OFFER_CLOSED notification #15

Closed
floorjubbega opened this issue Jul 31, 2020 · 0 comments
Closed

The plugin does not handle the OFFER_CLOSED notification #15

floorjubbega opened this issue Jul 31, 2020 · 0 comments

Comments

@floorjubbega
Copy link

Describe the bug
The OFFER_CLOSED notifications are not incorporated yet, which is causing a large number of "open" orders on Shopware's side. The OFFER_CLOSED notification can be used for closing the orders that were abandoned by the shopper, and make sure the inventory is available after 12 hours.

To Reproduce
Steps to reproduce the behavior:

  1. Abandon an initiated transaction
  2. Offers created within Shopware
  3. Offers will remain open

Expected behavior
The order should be closed so the inventory is available to the merchant.
runelaenen pushed a commit to runelaenen/adyen-shopware5 that referenced this issue Aug 11, 2020
Fixes Adyen#15 Handle offer_closed notification
662f85a
@runelaenen runelaenen mentioned this issue Aug 11, 2020
Merged
acampos1916 added a commit that referenced this issue Sep 10, 2020
@acampos1916 @maxwellpowers
@runelaenen @wannevancamp @vancaw1 @msilvagarcia
Release 1.5.0 (#53)
4371f95 
* [PW-2473]: Shopware review fixes and remove 3DS2 image size (#7)

* Shopware review fixes and remove 3DS2 image size

* Indentation fixes

* Hardcode 3DS image size

* Revert hardcode 3DS image size

* [PW-2562] Adjustments for phpcs (#9)

* Fixes and removing phpcs exclude patterns in favor of specific rules suppression

* New phpcs version and ignore/disable sniffs

* Adjusting copyright comment

* Update composer.json (#31)

To correctly install the plugin via composer, the module directory needs to be renamed to 'AdyenPayment'.

* Fix #19 PW-2601 Update completed state (#34)

* Fix #22 PW-2743 Show error on 404 (#35)

Shows error message when 404 is returned from Test button. This means the plugin is not active.

* PW-2603 remove customer id from shopperinfo payload (#33)

Co-authored-by: Wanne Van Camp <[email protected]>

* Fixing Yandex logo (#40)

* Improve exception logging (#37)

Fix #23 PW-2747

* Fixes #15 Handle offer_closed notification (#39)

* Fixes #15 Handle offer_closed notification

* PW-2748 Tabs -> spaces

* Fixes #18 PW-2600 Catch exception during backend Test (#38)

* Fixes #18 PW-2600 Catch exception during backend Test

* PW-2600 Tabs to spaces

* PW-2804 Save form before test (#36)

Saves the config before the test is ran.

Fix #24

* PW-2565 Make paymentsmethod cache configurable (#43)

Adds configuration option to make caching of /paymentmethods call configurable.

Co-authored-by: Ángel Campos <[email protected]>

Fixes #26

* PW-2505 Distinquish fields of test and live (#44)

* PW-2505 Distinquish fields of test and live

* PW-2505 Remove debug lines

* Improve labels

Co-authored-by: Ángel Campos <[email protected]>

Co-authored-by: Marcos Garcia <[email protected]>
Co-authored-by: Ángel Campos <[email protected]>

* Fixes #13 PW-2748 Add event to order restore (#42)

* Localizing changelog (#49)

* Feature/change refund function (#48)

* Save successful psp reference to PaymentInfo

* Fixes #17 Use succesfull notification for refunds

* Changing API test error code from 500 to 400 (#52)

* Fixing changelog

* 1.5.0 version bump

* Adding N/A to houseNumberOrName in Components/Payload/Providers/ShopperInfoProvider.php

Co-authored-by: maxwellpowers <[email protected]>
Co-authored-by: Rune Laenen <[email protected]>
Co-authored-by: Wanne Van Camp <[email protected]>
Co-authored-by: Wanne Van Camp <[email protected]>
Co-authored-by: Rune Laenen <[email protected]>
Co-authored-by: Marcos Garcia <[email protected]>
wannevancamp pushed a commit to wannevancamp/adyen-shopware5 that referenced this issue Sep 25, 2020
@vancaw1
Merge branch 'develop' into Adyen#54-cronjobs-not-running
9ddbab7 
* develop: (21 commits)
  Only send mail after succesful payment (Adyen#46)
  Adding N/A to houseNumberOrName in Components/Payload/Providers/ShopperInfoProvider.php
  1.5.0 version bump
  Fixing changelog
  Changing API test error code from 500 to 400 (Adyen#52)
  Feature/change refund function (Adyen#48)
  Localizing changelog (Adyen#49)
  Fixes Adyen#13 PW-2748 Add event to order restore (Adyen#42)
  PW-2505 Distinquish fields of test and live (Adyen#44)
  PW-2565 Make paymentsmethod cache configurable (Adyen#43)
  PW-2804 Save form before test (Adyen#36)
  Fixes Adyen#18 PW-2600 Catch exception during backend Test (Adyen#38)
  Fixes Adyen#15 Handle offer_closed notification (Adyen#39)
  Improve exception logging (Adyen#37)
  Fixing Yandex logo (Adyen#40)
  PW-2603 remove customer id from shopperinfo payload (Adyen#33)
  Fix Adyen#22 PW-2743 Show error on 404 (Adyen#35)
  Fix Adyen#19 PW-2601 Update completed state (Adyen#34)
  Update composer.json (Adyen#31)
  [PW-2562] Adjustments for phpcs (Adyen#9)
  ...

# Conflicts:
#	plugin.xml
acampos1916 added a commit that referenced this issue Sep 30, 2020
@acampos1916 @maxwellpowers
@runelaenen @wannevancamp @vancaw1 @msilvagarcia
Release 1.5.1 (#57)
85530d1 
* [PW-2473]: Shopware review fixes and remove 3DS2 image size (#7)

* Shopware review fixes and remove 3DS2 image size

* Indentation fixes

* Hardcode 3DS image size

* Revert hardcode 3DS image size

* [PW-2562] Adjustments for phpcs (#9)

* Fixes and removing phpcs exclude patterns in favor of specific rules suppression

* New phpcs version and ignore/disable sniffs

* Adjusting copyright comment

* Update composer.json (#31)

To correctly install the plugin via composer, the module directory needs to be renamed to 'AdyenPayment'.

* Fix #19 PW-2601 Update completed state (#34)

* Fix #22 PW-2743 Show error on 404 (#35)

Shows error message when 404 is returned from Test button. This means the plugin is not active.

* PW-2603 remove customer id from shopperinfo payload (#33)

Co-authored-by: Wanne Van Camp <[email protected]>

* Fixing Yandex logo (#40)

* Improve exception logging (#37)

Fix #23 PW-2747

* Fixes #15 Handle offer_closed notification (#39)

* Fixes #15 Handle offer_closed notification

* PW-2748 Tabs -> spaces

* Fixes #18 PW-2600 Catch exception during backend Test (#38)

* Fixes #18 PW-2600 Catch exception during backend Test

* PW-2600 Tabs to spaces

* PW-2804 Save form before test (#36)

Saves the config before the test is ran.

Fix #24

* PW-2565 Make paymentsmethod cache configurable (#43)

Adds configuration option to make caching of /paymentmethods call configurable.

Co-authored-by: Ángel Campos <[email protected]>

Fixes #26

* PW-2505 Distinquish fields of test and live (#44)

* PW-2505 Distinquish fields of test and live

* PW-2505 Remove debug lines

* Improve labels

Co-authored-by: Ángel Campos <[email protected]>

Co-authored-by: Marcos Garcia <[email protected]>
Co-authored-by: Ángel Campos <[email protected]>

* Fixes #13 PW-2748 Add event to order restore (#42)

* Localizing changelog (#49)

* Feature/change refund function (#48)

* Save successful psp reference to PaymentInfo

* Fixes #17 Use succesfull notification for refunds

* Changing API test error code from 500 to 400 (#52)

* Fixing changelog

* 1.5.0 version bump

* Adding N/A to houseNumberOrName in Components/Payload/Providers/ShopperInfoProvider.php

* Only send mail after succesful payment (#46)

* Only send mail after succesful payment

* Fixes #12 Tabs to spaces

* Fix indentation

* Fix indentation

Co-authored-by: Marcos Garcia <[email protected]>
Co-authored-by: Ángel Campos <[email protected]>

* #54 cronjobs not running (#55)

Add missing service registration

* add redirect  data to payments request (#56)

Co-authored-by: Wanne Van Camp <[email protected]>

* 1.5.1 changelog

Co-authored-by: maxwellpowers <[email protected]>
Co-authored-by: Rune Laenen <[email protected]>
Co-authored-by: Wanne Van Camp <[email protected]>
Co-authored-by: Wanne Van Camp <[email protected]>
Co-authored-by: Rune Laenen <[email protected]>
Co-authored-by: Marcos Garcia <[email protected]>
This was referenced Jan 26, 2021
Closed
Closed
@sheitmeier sheitmeier mentioned this issue Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@floorjubbega