Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cronjobs are not running #54

Closed
EggersS1 opened this issue Sep 15, 2020 · 6 comments
Closed

Cronjobs are not running #54

EggersS1 opened this issue Sep 15, 2020 · 6 comments

Comments

@EggersS1
Copy link

Describe the bug
Recurring payments are not going out from the AboCommerce (Shopware 5) to Adyen to support subscription payments.

PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function AdyenPayment\Components\NotificationProcessor\Authorisation::__construct(), 3 passed in /var/customers/webs/draeger/ppe-shop/var/cache/production_202005221140/proxies/ShopwareProduction3362b35eaa965cff4f4fccda9aa2ef9f3ec56040ProjectContainer.php on line 6526 and exactly 4 expected in /var/customers/webs/draeger/ppe-shop/custom/plugins/AdyenPayment/Components/NotificationProcessor/Authorisation.php:49
Stack trace:
#0 /var/customers/webs/draeger/ppe-shop/var/cache/production_202005221140/proxies/ShopwareProduction3362b35eaa965cff4f4fccda9aa2ef9f3ec56040ProjectContainer.php(6526): AdyenPayment\Components\NotificationProcessor\Authorisation->__construct()
#1 /var/customers/webs/draeger/ppe-shop/vendor/symfony/dependency-injection/Container.php(306): ShopwareProduction3362b35eaa965cff4f4fccda9aa2ef9f3ec56040ProjectContainer->getAdyenPayment_Components_NotificationProcessor_AuthorisationService()
#2 /var/customers/webs/draeger/ppe-shop/engine/Shopware/Compo in /var/customers/webs/draeger/ppe-shop/custom/plugins/AdyenPayment/Components/NotificationProcessor/Authorisation.php on line 49

To Reproduce
Steps to reproduce the behavior:

  1. Adyen plug in approved in Shopware 5 backend
  2. Cronjub is runnning
  3. Payment trigger isn't sent to Adyen
  4. See error

Expected behavior
Subscription payments are able to process via digital payment provider

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari, mozilla]

Additional context
Add any other context about the problem here.
@Byorun
Copy link

Byorun commented Sep 15, 2020 •
edited
Loading

The component.xml is missing the new 4th parameter https://github.com/Adyen/adyen-shopware5/blob/8c3b08f3d613fe07b364b66c74d36240d73f9d81/Resources/services/components.xml#L81l

@EggersS1
Copy link
Author

Hi Byorun, many thanks for the reply. we are using the standard plug in from adyen. Has adyen to change it in the plug in or is supposed to change something?

@Byorun
Copy link

Byorun commented Sep 18, 2020

@EggersS1 This is a bug in the current version of the plugin, we already notified adyen about it, my guess is that we will soon see a 1.5.1 hotfix.

If you can't wait for a fix you can add
<argument type="service" id="models"/>
as the 4th argument parameter for the service registration in Resources/services/component.xml for adyen_payment.components.notification_processor.authorisation and adyen_payment.components.notification_processor.capture

@wannevancamp wannevancamp mentioned this issue Sep 24, 2020
Merged
wannevancamp pushed a commit to wannevancamp/adyen-shopware5 that referenced this issue Sep 25, 2020
@vancaw1
Merge branch 'develop' into Adyen#54-cronjobs-not-running
9ddbab7 
* develop: (21 commits)
  Only send mail after succesful payment (Adyen#46)
  Adding N/A to houseNumberOrName in Components/Payload/Providers/ShopperInfoProvider.php
  1.5.0 version bump
  Fixing changelog
  Changing API test error code from 500 to 400 (Adyen#52)
  Feature/change refund function (Adyen#48)
  Localizing changelog (Adyen#49)
  Fixes Adyen#13 PW-2748 Add event to order restore (Adyen#42)
  PW-2505 Distinquish fields of test and live (Adyen#44)
  PW-2565 Make paymentsmethod cache configurable (Adyen#43)
  PW-2804 Save form before test (Adyen#36)
  Fixes Adyen#18 PW-2600 Catch exception during backend Test (Adyen#38)
  Fixes Adyen#15 Handle offer_closed notification (Adyen#39)
  Improve exception logging (Adyen#37)
  Fixing Yandex logo (Adyen#40)
  PW-2603 remove customer id from shopperinfo payload (Adyen#33)
  Fix Adyen#22 PW-2743 Show error on 404 (Adyen#35)
  Fix Adyen#19 PW-2601 Update completed state (Adyen#34)
  Update composer.json (Adyen#31)
  [PW-2562] Adjustments for phpcs (Adyen#9)
  ...

# Conflicts:
#	plugin.xml
cyattilakiss pushed a commit that referenced this issue Sep 25, 2020
@wannevancamp
#54 cronjobs not running (#55)
ab7044b 
Add missing service registration
@EggersS1
Copy link
Author

Hi acampos1916, does it mean that cronjobs now are possible to make? and that it support subscritpion models?

@EggersS1
Copy link
Author

Greate to see is there already a date published when the release with bug fixes will be available?

@cyattilakiss
Copy link
Contributor

Greate to see is there already a date published when the release with bug fixes will be available?

Hi @EggersS1 ,
@acampos1916 is working on the release at the moment, hopefully it will be published today 👍
Best,
Attila
Adyen

acampos1916 added a commit that referenced this issue Sep 30, 2020
@acampos1916 @maxwellpowers
@runelaenen @wannevancamp @vancaw1 @msilvagarcia
Release 1.5.1 (#57)
85530d1 
* [PW-2473]: Shopware review fixes and remove 3DS2 image size (#7)

* Shopware review fixes and remove 3DS2 image size

* Indentation fixes

* Hardcode 3DS image size

* Revert hardcode 3DS image size

* [PW-2562] Adjustments for phpcs (#9)

* Fixes and removing phpcs exclude patterns in favor of specific rules suppression

* New phpcs version and ignore/disable sniffs

* Adjusting copyright comment

* Update composer.json (#31)

To correctly install the plugin via composer, the module directory needs to be renamed to 'AdyenPayment'.

* Fix #19 PW-2601 Update completed state (#34)

* Fix #22 PW-2743 Show error on 404 (#35)

Shows error message when 404 is returned from Test button. This means the plugin is not active.

* PW-2603 remove customer id from shopperinfo payload (#33)

Co-authored-by: Wanne Van Camp <[email protected]>

* Fixing Yandex logo (#40)

* Improve exception logging (#37)

Fix #23 PW-2747

* Fixes #15 Handle offer_closed notification (#39)

* Fixes #15 Handle offer_closed notification

* PW-2748 Tabs -> spaces

* Fixes #18 PW-2600 Catch exception during backend Test (#38)

* Fixes #18 PW-2600 Catch exception during backend Test

* PW-2600 Tabs to spaces

* PW-2804 Save form before test (#36)

Saves the config before the test is ran.

Fix #24

* PW-2565 Make paymentsmethod cache configurable (#43)

Adds configuration option to make caching of /paymentmethods call configurable.

Co-authored-by: Ángel Campos <[email protected]>

Fixes #26

* PW-2505 Distinquish fields of test and live (#44)

* PW-2505 Distinquish fields of test and live

* PW-2505 Remove debug lines

* Improve labels

Co-authored-by: Ángel Campos <[email protected]>

Co-authored-by: Marcos Garcia <[email protected]>
Co-authored-by: Ángel Campos <[email protected]>

* Fixes #13 PW-2748 Add event to order restore (#42)

* Localizing changelog (#49)

* Feature/change refund function (#48)

* Save successful psp reference to PaymentInfo

* Fixes #17 Use succesfull notification for refunds

* Changing API test error code from 500 to 400 (#52)

* Fixing changelog

* 1.5.0 version bump

* Adding N/A to houseNumberOrName in Components/Payload/Providers/ShopperInfoProvider.php

* Only send mail after succesful payment (#46)

* Only send mail after succesful payment

* Fixes #12 Tabs to spaces

* Fix indentation

* Fix indentation

Co-authored-by: Marcos Garcia <[email protected]>
Co-authored-by: Ángel Campos <[email protected]>

* #54 cronjobs not running (#55)

Add missing service registration

* add redirect  data to payments request (#56)

Co-authored-by: Wanne Van Camp <[email protected]>

* 1.5.1 changelog

Co-authored-by: maxwellpowers <[email protected]>
Co-authored-by: Rune Laenen <[email protected]>
Co-authored-by: Wanne Van Camp <[email protected]>
Co-authored-by: Wanne Van Camp <[email protected]>
Co-authored-by: Rune Laenen <[email protected]>
Co-authored-by: Marcos Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Byorun @acampos1916 @cyattilakiss @EggersS1