Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#607 Add minimum and maximum record length option. #609

Merged
merged 10 commits into from
Apr 21, 2023

Conversation

yruslan
Copy link
Collaborator

@yruslan yruslan commented Apr 20, 2023

This could help filtering out incorrect records, especially from ASCII files.

@yruslan yruslan force-pushed the feature/607-add-minimum-record-length-option branch from 277d2ff to 3423772 Compare April 20, 2023 08:58
@github-actions
Copy link

github-actions bot commented Apr 20, 2023

JaCoCo code coverage report - scala 2.11.12 - spark 2.4.8

File Coverage [63.29%]
CobolScanners.scala 96.38% 🍏
SparkCobolOptionsBuilder.scala 87.21% 🍏
CobolParametersParser.scala 79.67%
FixedLenTextReader.scala 18.62%
FixedLenNestedReader.scala 16.74%
VRLRecordReader.scala 0%
Total Project Coverage 71.39% 🍏

@github-actions
Copy link

github-actions bot commented Apr 20, 2023

JaCoCo code coverage report - scala 2.13.10 - spark 3.3.2

File Coverage [33.39%]
CobolScanners.scala 94.2% 🍏
SparkCobolOptionsBuilder.scala 90.09% 🍏
CobolParametersParser.scala 78.3%
FixedLenTextReader.scala 17.71%
FixedLenNestedReader.scala 14.91%
ReaderParameters.scala 0%
CobolParameters.scala 0%
VRLRecordReader.scala 0%
Total Project Coverage 66.1% 🍏

@github-actions
Copy link

github-actions bot commented Apr 20, 2023

JaCoCo code coverage report - scala 2.12.17 - spark 3.2.3

File Coverage [63.99%]
CobolScanners.scala 94.59% 🍏
SparkCobolOptionsBuilder.scala 89.12% 🍏
CobolParametersParser.scala 78.97%
VRLRecordReader.scala 45.7%
FixedLenTextReader.scala 19.35%
FixedLenNestedReader.scala 16.46%
Total Project Coverage 76.47% 🍏

@miroslavpojer miroslavpojer self-requested a review April 20, 2023 11:17
@yruslan yruslan force-pushed the feature/607-add-minimum-record-length-option branch from 0271a59 to c565b8b Compare April 20, 2023 12:46
@yruslan
Copy link
Collaborator Author

yruslan commented Apr 21, 2023

Due to historical reasons when 'cobol-parser' and 'spark-cobol' were in a single module most tests are integration tests. After the split tests for 'cobol-parser' remained in 'spark-cobol' which affects coverage reports.

Here is the consolidated report from IntelliJ IDEA:
Screenshot 2023-04-21 at 14 42 58

Admin merging this issue now. The Jacoco plugin will be adjusted according to the historical project structure in a future PR.

@yruslan yruslan merged commit c069a0b into master Apr 21, 2023
@yruslan yruslan deleted the feature/607-add-minimum-record-length-option branch April 21, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant