#602 - Add GitHub action for code-coverage check #603
Conversation
- Update of plugins file to support current Absa-JaCoCo workaround. - New yml file for server side check.
- Fix runtime problems. - Update Absa sbt-jacoco plugin.
- Add paths to modules to reach jacoco xml files.
- Fix of yml file.
- Fix of yml file. - Remove path to xml file with empty jacoco output.
JaCoCo code coverage report - scala 2.12.17 - spark 3.2.3
|
JaCoCo code coverage report - scala 2.11.12 - spark 2.4.8
|
JaCoCo code coverage report - scala 2.13.10 - spark 3.3.2
|
- Removed old version of plugin.
| min-coverage-overall: ${{ matrix.overall }} | ||
| min-coverage-changed-files: ${{ matrix.changed }} |
| @@ -80,10 +80,12 @@ lazy val cobolConverters = (project in file("cobol-converters")) | |||
| // No need to publish this artifact since it has test only at the moment | |||
| publishArtifact := false, | |||
| publish := {}, | |||
| publishLocal := {}, | |||
| publishLocal := {} | |||
| ).dependsOn(cobolParser) | |||
There was a problem hiding this comment.
The parser contains some generated code. Is it possible to exclude
cobol-parser/src/main/scala/za/co/absa/cobrix/cobol/parser/antlr/*.java
from coverage checks (for both overall and changed files) ?
There was a problem hiding this comment.
*.java files should be excluded already. Current target of code-coverage are *.scala files.
But yes, there is possible to define excludes. See code in build.sbt for prepared example:
lazy val commonJacocoExcludes: Seq[String] = Seq( // "za.co.absa.cobrix.spark.cobol.reader.FixedLenTextReader*", // class and related objects // "za.co.absa.cobrix.spark.cobol.reader.RowHandler" // class only )
miroslavpojer
deleted the
feature/add_github_action_for_code_coverage_check
branch
Closes #602