Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to specify minimum record length #607

Closed
yruslan opened this issue Apr 17, 2023 · 0 comments
Closed

Add an option to specify minimum record length #607

yruslan opened this issue Apr 17, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@yruslan
Copy link
Collaborator

yruslan commented Apr 17, 2023

Background

This come from an issue with some ASCII files, but is relevant to EBCDIC as well.

Cobrix ignores all empty lines of ASCII files. But some files contain EOF character at the end:

aaaa bbbb 1234
cccc dddd 5678
EOF

Since there is a character in a row, it is treated as a record resulting one additional record:

+-----+-----+-----+
|A    |B    |C    |
+-----+-----+-----+
|aaaa |bbbb |1234 |
|cccc |dddd |5678 |
|null |null |null |
+-----+-----+-----+

Should be

+-----+-----+-----+
|A    |B    |C    |
+-----+-----+-----+
|aaaa |bbbb |1234 |
|cccc |dddd |5678 |
+-----+-----+-----+

Feature

Add an option to specify minimum record length.

Proposed Solution

.option("minimum_record_length", 2)

@yruslan yruslan added the enhancement New feature or request label Apr 17, 2023
@yruslan yruslan self-assigned this Apr 17, 2023
yruslan added a commit that referenced this issue Apr 18, 2023
yruslan added a commit that referenced this issue Apr 19, 2023
…ptions

are supported by readers that work with RDW and BDW headers.
yruslan added a commit that referenced this issue Apr 20, 2023
yruslan added a commit that referenced this issue Apr 20, 2023
…ptions

are supported by readers that work with RDW and BDW headers.
yruslan added a commit that referenced this issue Apr 21, 2023
yruslan added a commit that referenced this issue Apr 21, 2023
…ptions

are supported by readers that work with RDW and BDW headers.
@yruslan yruslan closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant