-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/frozen grid closes request #26 #311
Conversation
- fixed grid menu, accordion, select2 editor
- when using checkbox selector as a single row selection, we need a way to hide the "Select All" checkbox - also added getOptions/setOptions to dynamically change options on the fly
- exposing the init() function helps dealing with i18n translation without losing any Slick.Event attached like onColumnsChanged
JS and HTML are text files, so they should be checked be CRLF for Windows and LF for Linux slick.grid.js was in CRLF
as per commit #b2459b9905e0a3597ee00148982b1fd172c29a1a JS and HTML are text files, so they should be checked be CRLF for Windows and LF for Linux slick.grid.js was in CRLF
as per commit 09962d9
and remove grid:self spec from all trigger calls arg lists as it is added in in the trigger function as per commit 93f043f
- add a way to show the Checkbox Selector (select all) inside the Header Row (aka Filter row) via a new flag boolean "showInFilterHeaderRow" false by defaults - keep previous behavior of showing Checkbox Select in the Column Header Title Row, via a new flag "showInColumnTitleRow", true by default - both flags can be used (and tested) together, but most often used separately
- also added Font-Awesome checkbox icons to demo
- to be consistent with all other flags, the 2 new flags are - hideInColumnTitleRow: false by default - hideInFilterHeaderRow: true by default
* feat(RowDetail): add 2x new subscribe methods & fixed multiple issues
…256) * refactor: Sort and add trailing newline to .npmignore - misc: Exclude tests and examples from npm package
as per commit aee3ee8
- because the notify is now in updateGroupBy(), the notify in clearDroppedGroups() becomes redundant is unnecessary
- this helps in knowing who caller the update action and user can do certain thing accordingly with this new info
* row detail view - provide alternative calculation The function `calculateOutOfRangeViews()` is somehow complex and doesn't work correctly on my side, however a much simpler version always work for me and I'm providing it as an alternative calculation method that can be enabled by a new flag "useSimpleViewportCalc" (which is disabled by default to keep previous behavior). * row detail, fix rendered count calculation * row detail, switch to using RowId instead of RowIndex - the RowIndex can be problematic when user does filtering, the rowIndex is then offset, while if we use the rowId (id of the row datacontext object) this is always valid for calculation
- without the fix, if 2 grids exists in the same page and 1 has header row showing, and the 2nd grid is not, 1 grid will affect the other. The fix is to use the grid UID to avoid such problems.
as per commit aa3e7a5
if true don't set x-overflow to hidden as per commit 044b31e
- fixed explicit initialization example by css position
- instead of using jquery directly, we need to use the grid function to toggle pre-header
@6pac I know it's a big one, but let me know if there's something you want to know about. |
A huge thanks to you @ghiscoding , this was a mammoth task. Props to all the other testers and contibutors as well, notably you @ingodjango. |
Indeed a very lengthy feature, and yes thanks to @ingodjango which got me back into finishing it :) I'm already starting to create an example with my repos, looking good so far. |
@6pac Yeah I see the older version |
Damn. OK. |
@6pac Now it's holiday time... |
Closes #26