Feature/row detail view #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collapsedClass: Extra classes to be added to the collapse Toggle These are added so we can add more classes to the expanders icon
…h internal scrolls) Updated what we take the height from to the scrollHeight to deal with tab heigh issue. Added save for after resize of the expanded view is fired
Have put in an excessive check version of the calculateOutOfRangeViews function that should have most if not all edge cases covered.
Moved same check to be the first thing
Updated the save to only care about the part in the buffering area that is appropriate
…view and now just needs to be called
Added maxRows so that we can define what the maxRows for the expanding rows should be for resize. Updated the examples to allow for the manipulations
|
@SatanEnglish is it safe to say that this PR will also close your other issue #252 ? |
|
@ghiscoding Yes it's safe to say the PR will close #252 |
ghiscoding
added a commit
that referenced
this pull request
Dec 20, 2018
* feat(RowDetail): add 2x new subscribe methods & fixed multiple issues
alhoo
pushed a commit
to alhoo/SlickGrid
that referenced
this pull request
Dec 22, 2018
* feat(RowDetail): add 2x new subscribe methods & fixed multiple issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #281 which was fully tested by @ghiscoding and @SatanEnglish
This PR also closes #252
onRowOutOfViewportRangesubscribeonRowBackToViewportRangesubscribecollapseDetailViewpublicexpandDetailViewpublickeyPrefixproperty to change the key prefix of all metadata used by the plugin that appears on the item objectcollapseAllOnSortboolean flag to provide possibility to implement it's own code for on sortsaveDetailViewOnScrollboolean flag because saving detail is not used by all frontend frameworksitemeverywhere instead ofitemDetailin some areas (however make it to work with both so that it doesn't break anyone's code)cssClasswhich was not fully implemented in the codegetFilterItemto takes in the item we are filtering and if it is an expanded row returns it's parents row to filter onexample16-row-detail.htmlonScrollcode more efficientThere's a lot of changes, but I believe that it will be a simple plug & play for most users. The biggest feature is the additions of 2x new subscribe methods to let the user know when the Row Detail View is out or back to visible range. Also a working sample with Filters is a nice addition.