Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented dependency on jquery-ui? #277

Closed
Yoten opened this issue Sep 21, 2018 · 1 comment
Closed

Undocumented dependency on jquery-ui? #277

Yoten opened this issue Sep 21, 2018 · 1 comment

Comments

@Yoten
Copy link

Yoten commented Sep 21, 2018

Per the wiki, jQueryUI is only required when using column reordering. However, in slick.groupitemmetadataprovider.js line 115, there's a reference to "$.ui.keyCode.SPACE" as part of an onKeyDown event handler that I don't think is explicitly linked to column reordering. This will throw an error if you don't have jQueryUI's keyCode part.

If that file isn't supposed to be dependent upon jQueryUI, it might be worth adding SPACE to the local keyCodes defined in slick.core.js.

@6pac
Copy link
Owner

6pac commented Sep 22, 2018

Done. Thanks for that catch. Will do new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants