🎉Bump Dart version required to run the app, and add in Dart 2.3 features.🎉 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigi-rosso
reviewed
Apr 23, 2019
| ) | ||
| ]..addAll(lineWidgets), | ||
| ), | ||
| ...lineWidgets |
luigi-rosso
reviewed
Apr 23, 2019
| ]..addAll( | ||
| bug.skillsNeeded.map((Skill skill) => SkillDot(skill)).toList(), | ||
| ), | ||
| for (Skill skill in bug.skillsNeeded) SkillDot(skill) |
|
LGTM. Does that mean we should all upgrade our Flutter SDK to some particular version? Sorry if I missed that elsewhere. |
filiph
approved these changes
Apr 23, 2019
|
@filiph Followed Emily's instructions above, latest Dev is working for me: |
Merged
|
Okay, I made the pubspec very strict about which version of Flutter you're running. This is to ensure reproducibility and so that we can test stability of this branch prior to I/O as much as possible. It's flutter commit hash b593f5167bce84fb3cad5c258477bf3abc1b14eb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉Attention! Attention! 🎉
I'm looking at bumping up the minimum Dart version so that Emily and I can showcase the new Dart features in our I/O talk.
This means that you need will need to be on the Flutter dev branch right now at a minimum (could be master if you're feeling adventurous) (and if you are and this doesn't work, just make sure that you've run
flutter upgradesince last Friday).I'm tagging you all just so you can know, and upgrade your flutter version before I actually commit this. I don't feel like it actually really needs review; it's pretty simple.