Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Bump Dart version required to run the app, and add in Dart 2.3 features.🎉 #41

Merged
merged 5 commits into from
Apr 23, 2019
Merged

🎉Bump Dart version required to run the app, and add in Dart 2.3 features.🎉 #41

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
261bf41
Bump Dart version required to run the app, and add in Dart 2.3 features.
efortuna Apr 23, 2019
9811648
be more specific with which dev version we want
efortuna Apr 23, 2019
9ff33ef
be really strict with the Flutter checkout version you use.
efortuna Apr 23, 2019
1fea14a
merged with master
efortuna Apr 23, 2019
bda6b98
remvoe unused import
efortuna Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/src/widgets/task_picker/task_picker_task.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,9 @@ class TaskPickerTask extends StatelessWidget {
),
),
),
)
]..addAll(lineWidgets),
),
...lineWidgets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! (╯°□°）╯︵ ┻━┻

],
),
);
}
Expand Down
5 changes: 2 additions & 3 deletions lib/src/widgets/work_items/bug_header.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@ class BugHeader extends StatelessWidget {
children: [
const Icon(Icons.bug_report, color: bugColor),
Expanded(child: Container()),
]..addAll(
bug.skillsNeeded.map((Skill skill) => SkillDot(skill)).toList(),
),
for (Skill skill in bug.skillsNeeded) SkillDot(skill)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

]
);
}
}
5 changes: 2 additions & 3 deletions lib/src/widgets/work_items/task_header.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,8 @@ class TaskHeader extends StatelessWidget {
style: contentSmallStyle,
),
Expanded(child: Container()),
]..addAll(
blueprint.skillsNeeded.map((Skill skill) => SkillDot(skill)).toList(),
),
for (Skill skill in blueprint.skillsNeeded) SkillDot(skill)
],
);
}
}
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ description: Become a tech lead, slay bugs, and don't get fired.
version: 1.0.0+1

environment:
sdk: ">=2.2.0 <3.0.0"
sdk: ">=2.3.0-dev <3.0.0"

dependencies:
flutter:
Expand Down