Fix CI errors

[efortuna]

No description provided.

[efortuna]

ahhh nooo what is wrong now?

[luigi-rosso]

I think I must not be disposing a timer or an animation controller somewhere.

[luigi-rosso]

Looking into it!

[efortuna]

okay. I'm going to push this at least

[luigi-rosso]

I couldn't find anything yet, but I do see the test failing locally too. All timers seem to be canceled and animations disposed. I couldn't find any delayed futures either.

[filiph]

This does not fail locally for me. I noticed this is running on master of Flutter. Might that be the problem? See also #32 (comment).

[luigi-rosso]

Oh interesting, yes we are using master. What should we change it to? You can change this directly here:
https://github.com/2d-inc/dev_rpg/blob/101bd8232fdd91c71e46a3ecc157cfed1d2d5d1d/.circleci/config.yml#L21

[brianegan]

Per #41, I'd say let's go with the dev branch. It has the required Dart version we need but might be just a little more stable than master.

[brianegan]

Update: Even on dev branch this test fails (also fails locally for me). See #45

[filiph]

Ok, I have a new theory. The smoke test fails because it's waiting for Flare assets (there's a long standing issue in which assets are not loading by default with the test runner, and I see that Flare is waiting for those assets without cancelling when disposed).

Over at #39 I'm adding some more tests (mostly for show, tbh — I need tests for our I/O session) and I'm skipping the smoke test. If I have time this week, I can take a closer look at the smoke test and un-skip it. But I don't want us to wait on that.

I also switched to dev branch instead of master. On master, I saw a really bizarre Uint16List/Int32List error that I don't think we want to deal with. master is not nearly stable enough for serious development, it's literally tip of tree.

Now it's green over at #39.

[luigi-rosso]

The Uint16/Int32List error is a breaking change that was committed to the engine yesterday:
flutter/engine@ed1f3fd

We're also tracking it here:
2d-inc/Flare-Flutter#75 (comment)

In the meantime I can take a look at the asset loading disposing properly.