Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade provider to 2.0.0-dev #32

Merged
merged 4 commits into from
Apr 22, 2019
Merged

Upgrade provider to 2.0.0-dev #32

merged 4 commits into from
Apr 22, 2019

Conversation

filiph
Copy link
Collaborator

@filiph filiph commented Apr 22, 2019

I have more ideas on how to really use the new version, but first I wanted to land the most straightforward upgrade.

@filiph
Copy link
Collaborator Author

filiph commented Apr 22, 2019

@brianegan - the CI fails despite it doing just fine on my end. I suspect this is because we're checking out master branch of Flutter. (It's also very possible that I have a bug somewhere, but it's hard for me to debug. I'd have to constantly switch between master and a more stable version.)

Maybe we should agree on a version / channel of Flutter to CI test this on.

cc @efortuna

Copy link
Collaborator

@efortuna efortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efortuna
Copy link
Collaborator

Yeah the CI checks are always failing on my PRs....I admit I've been ignoring them :-/

@luigi-rosso
Copy link
Contributor

Here are some of the latest errors in Circle:
Screen Shot 2019-04-22 at 4 05 45 PM
Screen Shot 2019-04-22 at 4 06 27 PM
Screen Shot 2019-04-22 at 4 06 50 PM

@efortuna
Copy link
Collaborator

Sending a PR to clean up then

@filiph filiph mentioned this pull request Apr 22, 2019
@filiph
Copy link
Collaborator Author

filiph commented Apr 22, 2019

I'm going to merge this. The fail was there before this change.

@filiph filiph merged commit d5e9f6a into master Apr 22, 2019
@filiph filiph deleted the upgrade_provider branch April 22, 2019 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants