-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SimpleForm USWDS-styled radio_buttons default #5933
Conversation
I agree that "Login.gov allows you..." line above the radio group is semantically hint text. I'm OK with this as-is, but would prefer if it wasn't italic because it's a full sentence. Looping in @nickttng who has worked on hint text more - thoughts about whether we should move from Italic to Regular for hint text at the design system level in case of longer hints, or make an individual override here? |
Yes, I'm inclined to move from italic to regular for hint text at the design system level since we are seeing more use cases for it. Initially, it has been designed to make a short text stands out, but with this and contact form as examples, it becomes clear that hint text should be easy to read. Regardless if it's short or a full sentence. |
Sounds good to me! I can patch in the change here and create a corresponding pull request in the design system. |
**Why**: Per discussion in 18F/identity-idp#5933, to better support a broader set of use-cases, including long hint text.
Patch: 286eed9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
**Why**: Per discussion in 18F/identity-idp#5933, to better support a broader set of use-cases, including long hint text.
**Why**: So that a developer can easily display a collection of radio button input options with consistent styles.
**Why**: We're gonna need it once the label global styles aren't around anymore
fb4a3b9
to
e5c8faf
Compare
* Add SimpleForm USWDS-styled radio_buttons default **Why**: So that a developer can easily display a collection of radio button input options with consistent styles. * Hide hint on account edit language page * Patch hint text to normal style * Add usa-label styles to USWDS legend **Why**: We're gonna need it once the label global styles aren't around anymore
Why: So that a developer can easily display a collection of radio button input options with consistent styles (especially incorporating wrapping implementation introduced in #5906).
Draft: Still sorting out design/semantics around "Hint", related to Public Sans QA feedback (ties in to #5900)