Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimpleForm USWDS-styled radio_buttons default #5933

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Feb 11, 2022

Why: So that a developer can easily display a collection of radio button input options with consistent styles (especially incorporating wrapping implementation introduced in #5906).

Draft: Still sorting out design/semantics around "Hint", related to Public Sans QA feedback (ties in to #5900)

Before After
Screen Shot 2022-02-11 at 2 16 20 PM Screen Shot 2022-02-11 at 2 20 25 PM

@anniehirshman-gsa
Copy link
Contributor

I agree that "Login.gov allows you..." line above the radio group is semantically hint text.

I'm OK with this as-is, but would prefer if it wasn't italic because it's a full sentence. Looping in @nickttng who has worked on hint text more - thoughts about whether we should move from Italic to Regular for hint text at the design system level in case of longer hints, or make an individual override here?

@nickttng
Copy link
Member

Yes, I'm inclined to move from italic to regular for hint text at the design system level since we are seeing more use cases for it. Initially, it has been designed to make a short text stands out, but with this and contact form as examples, it becomes clear that hint text should be easy to read. Regardless if it's short or a full sentence.

@aduth
Copy link
Member Author

aduth commented Feb 11, 2022

Yes, I'm inclined to move from italic to regular for hint text at the design system level since we are seeing more use cases for it. Initially, it has been designed to make a short text stands out, but with this and contact form as examples, it becomes clear that hint text should be easy to read. Regardless if it's short or a full sentence.

Sounds good to me! I can patch in the change here and create a corresponding pull request in the design system.

aduth added a commit to 18F/identity-design-system that referenced this pull request Feb 11, 2022
**Why**: Per discussion in 18F/identity-idp#5933, to better support a broader set of use-cases, including long hint text.
@aduth
Copy link
Member Author

aduth commented Feb 11, 2022

Sounds good to me! I can patch in the change here and create a corresponding pull request in the design system.

Patch: 286eed9
PR: 18F/identity-design-system#294

main Original proposal Updated proposal
Screen Shot 2022-02-11 at 2 16 20 PM Screen Shot 2022-02-11 at 2 16 21 PM Screen Shot 2022-02-11 at 2 20 25 PM

@aduth aduth marked this pull request as ready for review February 11, 2022 19:26
Copy link
Contributor

@anniehirshman-gsa anniehirshman-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

aduth added a commit to 18F/identity-design-system that referenced this pull request Feb 14, 2022
**Why**: Per discussion in 18F/identity-idp#5933, to better support a broader set of use-cases, including long hint text.
**Why**: So that a developer can easily display a collection of radio button input options with consistent styles.
**Why**: We're gonna need it once the label global styles aren't around anymore
@aduth aduth force-pushed the aduth-test-page-layouts branch from fb4a3b9 to e5c8faf Compare February 14, 2022 19:10
@aduth aduth merged commit e3f1224 into main Feb 15, 2022
@aduth aduth deleted the aduth-test-page-layouts branch February 15, 2022 15:29
mitchellhenke pushed a commit that referenced this pull request Feb 17, 2022
* Add SimpleForm USWDS-styled radio_buttons default

**Why**: So that a developer can easily display a collection of radio button input options with consistent styles.

* Hide hint on account edit language page

* Patch hint text to normal style

* Add usa-label styles to USWDS legend

**Why**: We're gonna need it once the label global styles aren't around anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants